New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Chat: Clients able to send messages in a room #90

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@abhsag24
Contributor

abhsag24 commented Dec 26, 2015

refinements are still left such as, username is not displayed, the basic framework is done.

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Dec 26, 2015

Contributor

unicode text is working.

Contributor

abhsag24 commented Dec 26, 2015

unicode text is working.

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Dec 31, 2015

Contributor

The current problem in chat is, there is
1.No UI to send Chat messages, right now.
2.if user types large messages, they are displayed on the screen, which disturbs the viewing experience

To tackle this problem we can
a. Stop displaying messages in the player altogether
or
b. Limit the length of message so that they are unobtrusive on the player (preferred)
or
c. Give the power to the client to stop displaying message on the screen in real time.

Contributor

abhsag24 commented Dec 31, 2015

The current problem in chat is, there is
1.No UI to send Chat messages, right now.
2.if user types large messages, they are displayed on the screen, which disturbs the viewing experience

To tackle this problem we can
a. Stop displaying messages in the player altogether
or
b. Limit the length of message so that they are unobtrusive on the player (preferred)
or
c. Give the power to the client to stop displaying message on the screen in real time.

@Uriziel

This comment has been minimized.

Show comment
Hide comment
@Uriziel

Uriziel Dec 31, 2015

Contributor

You have to rebase your changes away from your other PR though.

Contributor

Uriziel commented Dec 31, 2015

You have to rebase your changes away from your other PR though.

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Jan 1, 2016

Contributor

rebased away the changes in the other PR

Contributor

abhsag24 commented Jan 1, 2016

rebased away the changes in the other PR

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Jan 12, 2016

Contributor

another way we could stop large messages from displaying on the player is after a limit we could display only a certain part of the message, followed by "..." , rest of it could be read within the client or on the console

Contributor

abhsag24 commented Jan 12, 2016

another way we could stop large messages from displaying on the player is after a limit we could display only a certain part of the message, followed by "..." , rest of it could be read within the client or on the console

@Uriziel

This comment has been minimized.

Show comment
Hide comment
@Uriziel

Uriziel Jan 12, 2016

Contributor

How are you going to determine what's big message? (i.e. difference between fullHD and laptop screen)

Contributor

Uriziel commented Jan 12, 2016

How are you going to determine what's big message? (i.e. difference between fullHD and laptop screen)

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Jan 13, 2016

Contributor

a full hd screen can have more characters , but displaying a part of the message would only serve as a kind of notification, so displaying less characters on a bigger screen is not a big deal IMO.

Contributor

abhsag24 commented Jan 13, 2016

a full hd screen can have more characters , but displaying a part of the message would only serve as a kind of notification, so displaying less characters on a bigger screen is not a big deal IMO.

@remimarenco

This comment has been minimized.

Show comment
Hide comment
@remimarenco

remimarenco Jan 26, 2016

Contributor

Hey @abhsag24 , would be glad to help you on this!

Contributor

remimarenco commented Jan 26, 2016

Hey @abhsag24 , would be glad to help you on this!

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Jan 26, 2016

Contributor

@remimarenco would love to have help, as you can see i had already listed out the things that needed to be done further. What do you suggest?

Contributor

abhsag24 commented Jan 26, 2016

@remimarenco would love to have help, as you can see i had already listed out the things that needed to be done further. What do you suggest?

@remimarenco

This comment has been minimized.

Show comment
Hide comment
@remimarenco

remimarenco Jan 29, 2016

Contributor

@abhsag24 We should take some time to discuss about your vision on your branch, and see how we can work together on this.
Personally, I just want to be able to chat with my loved one while we are watching the movie. Annoying to have to use a third party system or to speak.

I found the letsgaze system pretty handy to handle the chat

Contributor

remimarenco commented Jan 29, 2016

@abhsag24 We should take some time to discuss about your vision on your branch, and see how we can work together on this.
Personally, I just want to be able to chat with my loved one while we are watching the movie. Annoying to have to use a third party system or to speak.

I found the letsgaze system pretty handy to handle the chat

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 10, 2016

I'm really looking forward to this functionality. I think having the conversation more closely tied with the on-screen action is essential for making it a more social experience.

Using Skype works and all, but I agree with @remimarenco that it's not always ideal to be on voice or to have to rely on another program to send text which requires keeping another window / screen active.

ghost commented Mar 10, 2016

I'm really looking forward to this functionality. I think having the conversation more closely tied with the on-screen action is essential for making it a more social experience.

Using Skype works and all, but I agree with @remimarenco that it's not always ideal to be on voice or to have to rely on another program to send text which requires keeping another window / screen active.

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Mar 10, 2016

Contributor

@perfectcolors and @remimarenco i think i've added the basic chat functionality in this PR already, you can go ahead and use it, but you'll have to chat from within the terminal and there are some concerns that i had stated earlier, i don't know much about the GUI and don't have the time right now to add that functionality :( , but it should be pretty usable :)

Contributor

abhsag24 commented Mar 10, 2016

@perfectcolors and @remimarenco i think i've added the basic chat functionality in this PR already, you can go ahead and use it, but you'll have to chat from within the terminal and there are some concerns that i had stated earlier, i don't know much about the GUI and don't have the time right now to add that functionality :( , but it should be pretty usable :)

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h
Contributor

Et0h commented Jul 3, 2016

@abhsag24

This comment has been minimized.

Show comment
Hide comment
@abhsag24

abhsag24 Jul 4, 2016

Contributor

awesome! so should i close this PR?

Contributor

abhsag24 commented Jul 4, 2016

awesome! so should i close this PR?

@Et0h Et0h referenced this pull request Jul 7, 2016

Closed

Add a chatbox #54

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Jul 7, 2016

Contributor

Closing this as PR has been accepted onto the chat branch.

Contributor

Et0h commented Jul 7, 2016

Closing this as PR has been accepted onto the chat branch.

@Et0h Et0h closed this Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment