New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Update nzbget-testing to version 17.x, c++14 required! #2185

Closed
schumi2004 opened this Issue Mar 12, 2016 · 19 comments

Comments

Projects
None yet
7 participants
@schumi2004
Contributor

schumi2004 commented Mar 12, 2016

As title says, please upgrade nzbget testing to version 17.x
http://pastebin.com/TaCUYebS

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 13, 2016

Member

This might not be possible. From what I see, C++ 14 is implemented fully in GCC5+. The DSM6RC toolchains are all GCC4.9.

Background of nzbget's reasoning here: nzbget/nzbget#88.

Member

Dr-Bean commented Mar 13, 2016

This might not be possible. From what I see, C++ 14 is implemented fully in GCC5+. The DSM6RC toolchains are all GCC4.9.

Background of nzbget's reasoning here: nzbget/nzbget#88.

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 13, 2016

Contributor

Ow, to bad then. I was expecting something like this.

Contributor

schumi2004 commented Mar 13, 2016

Ow, to bad then. I was expecting something like this.

@schumi2004 schumi2004 closed this Mar 13, 2016

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 13, 2016

Member

I would suggest to have a go at it with the DSM6RC toolchains anyway. Parts of the C++ 14 standard were introduced pre-GCC5, and that might be enough.

Member

Dr-Bean commented Mar 13, 2016

I would suggest to have a go at it with the DSM6RC toolchains anyway. Parts of the C++ 14 standard were introduced pre-GCC5, and that might be enough.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Mar 13, 2016

GCC 4.9 is OK for NZBGet v17. Although GCC 4.9 doesn't fully support C++14 I'm doing extra efforts to ensure NZBGet works with GCC 4.9.

checking whether /home/openelec/github/spksrc/toolchains/syno-alpine-5.2/work/arm-cortex_a15-linux-gnueabi/bin/arm-cortex_a15-linux-gnueabi-g++ supports C++14 features with -std=c++14... no

GCC 4.9 supports flag -std=c++14. Are you sure this is the output from GCC 4.9? Please post config.log, it usually includes full compiler versions.

hugbug commented Mar 13, 2016

GCC 4.9 is OK for NZBGet v17. Although GCC 4.9 doesn't fully support C++14 I'm doing extra efforts to ensure NZBGet works with GCC 4.9.

checking whether /home/openelec/github/spksrc/toolchains/syno-alpine-5.2/work/arm-cortex_a15-linux-gnueabi/bin/arm-cortex_a15-linux-gnueabi-g++ supports C++14 features with -std=c++14... no

GCC 4.9 supports flag -std=c++14. Are you sure this is the output from GCC 4.9? Please post config.log, it usually includes full compiler versions.

@GoodOmens83

This comment has been minimized.

Show comment
Hide comment
@GoodOmens83

GoodOmens83 Mar 13, 2016

Contributor

Tried compiling the latest 17 development version (from github) with the 6.0 beta2 toolchains and everything compiled fine. Can't test as I don't have 6.0 installed.

checking whether to test compiler features... yes
checking whether /home/xxx/spksrc/toolchains/syno-avoton-6.0/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-g++ supports C++14 features by default... no
checking whether /home/xxx/spksrc/toolchains/syno-avoton-6.0/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-g++ supports C++14 features with -std=c++14... yes

Contributor

GoodOmens83 commented Mar 13, 2016

Tried compiling the latest 17 development version (from github) with the 6.0 beta2 toolchains and everything compiled fine. Can't test as I don't have 6.0 installed.

checking whether to test compiler features... yes
checking whether /home/xxx/spksrc/toolchains/syno-avoton-6.0/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-g++ supports C++14 features by default... no
checking whether /home/xxx/spksrc/toolchains/syno-avoton-6.0/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-g++ supports C++14 features with -std=c++14... yes

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 14, 2016

Member

Thanks for the info @hugbug. The toolchain @schumi2004 was using is based on GCC4.6, so that's why those errors occurred (a lot of the NAS devices on the market use old versions of kernels/GCC/whatnot, which is a shame).

Seems that we shouldn't have an issue getting nzbget updated to latest once the final toolchains are included in spksrc, so that's good. Thanks for testing, @GoodOmens83.

Might as well reopen this issue so we can refer to it properly.

Member

Dr-Bean commented Mar 14, 2016

Thanks for the info @hugbug. The toolchain @schumi2004 was using is based on GCC4.6, so that's why those errors occurred (a lot of the NAS devices on the market use old versions of kernels/GCC/whatnot, which is a shame).

Seems that we shouldn't have an issue getting nzbget updated to latest once the final toolchains are included in spksrc, so that's good. Thanks for testing, @GoodOmens83.

Might as well reopen this issue so we can refer to it properly.

@Dr-Bean Dr-Bean reopened this Mar 14, 2016

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 14, 2016

Contributor

I'll do another attempt but it seems i don't have latest toolchain available in mij spksrc tree although it's updated.
Will report the outcome later today. (will manual add 6.0 toolchain)

Contributor

schumi2004 commented Mar 14, 2016

I'll do another attempt but it seems i don't have latest toolchain available in mij spksrc tree although it's updated.
Will report the outcome later today. (will manual add 6.0 toolchain)

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 14, 2016

Member

We haven't (and will not) add the DSM6RC (or the beta) toolchains. You can add one or more manually, e.g. copy a Makefile from an existing toolchain, and modify that.

Member

Dr-Bean commented Mar 14, 2016

We haven't (and will not) add the DSM6RC (or the beta) toolchains. You can add one or more manually, e.g. copy a Makefile from an existing toolchain, and modify that.

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 14, 2016

Contributor

Yeah did that but it returned an error.

This is my current make file http://pastebin.com/acSgxJ3W
And the error i get now http://pastebin.com/i7rdQrwE

Will check later today when i have more time.

Contributor

schumi2004 commented Mar 14, 2016

Yeah did that but it returned an error.

This is my current make file http://pastebin.com/acSgxJ3W
And the error i get now http://pastebin.com/i7rdQrwE

Will check later today when i have more time.

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 14, 2016

Member

Looks like a 32b host, and that's no good for DSM6 toolchains.

Member

Dr-Bean commented Mar 14, 2016

Looks like a 32b host, and that's no good for DSM6 toolchains.

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 14, 2016

Contributor

Is it? The spksrc readme suggest to use a 32b host instead of 64b.

Contributor

schumi2004 commented Mar 14, 2016

Is it? The spksrc readme suggest to use a 32b host instead of 64b.

@Dr-Bean

This comment has been minimized.

Show comment
Hide comment
@Dr-Bean

Dr-Bean Mar 14, 2016

Member

Yes, but we're in the process of changing that. See #2146

Member

Dr-Bean commented Mar 14, 2016

Yes, but we're in the process of changing that. See #2146

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Mar 14, 2016

@schumi2004: I can built NZBGet Linux installer of the current develop for you. Drop me a note via E-Mail with an info about CPU, if you are interested.

hugbug commented Mar 14, 2016

@schumi2004: I can built NZBGet Linux installer of the current develop for you. Drop me a note via E-Mail with an info about CPU, if you are interested.

@GoodOmens83

This comment has been minimized.

Show comment
Hide comment
@GoodOmens83

GoodOmens83 Mar 14, 2016

Contributor

@schumi2004: My test compile was done on Debian 64 virtual machine.

I can post my Makefile but I just copied a 5.2 toolchain (renaming it synology-6.0-...) and just replaced the url with the 6.0 beta2 url. make setup dsm-6.0 will allow you to compile for 6.0.

Contributor

GoodOmens83 commented Mar 14, 2016

@schumi2004: My test compile was done on Debian 64 virtual machine.

I can post my Makefile but I just copied a 5.2 toolchain (renaming it synology-6.0-...) and just replaced the url with the 6.0 beta2 url. make setup dsm-6.0 will allow you to compile for 6.0.

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 14, 2016

Contributor

@GoodOmens83 thanks i will try the same here.
@hugbug thanks for the offer but will first try it myself. for your reference, i was compiling it for a DS715, Alpine architecture.

Contributor

schumi2004 commented Mar 14, 2016

@GoodOmens83 thanks i will try the same here.
@hugbug thanks for the offer but will first try it myself. for your reference, i was compiling it for a DS715, Alpine architecture.

@schumi2004

This comment has been minimized.

Show comment
Hide comment
@schumi2004

schumi2004 Mar 28, 2016

Contributor

Did some more testing with different vm's etc but something seems to be wrong with busybox. I'll drop my attempts for now and wait until final toolchain is released. First need to fix other things that are broken by DMS6

Contributor

schumi2004 commented Mar 28, 2016

Did some more testing with different vm's etc but something seems to be wrong with busybox. I'll drop my attempts for now and wait until final toolchain is released. First need to fix other things that are broken by DMS6

@cytec

This comment has been minimized.

Show comment
Hide comment
@cytec

cytec Mar 31, 2016

Member

yeah would have been my suggestion too... DSM 6 seems to break like a lot... definitively to much for my liking to worry about a -testing package update... lets just hope they release the final TC's anytime soon and we don't have to wait ages

Member

cytec commented Mar 31, 2016

yeah would have been my suggestion too... DSM 6 seems to break like a lot... definitively to much for my liking to worry about a -testing package update... lets just hope they release the final TC's anytime soon and we don't have to wait ages

@d-zalewski

This comment has been minimized.

Show comment
Hide comment
@Safihre

This comment has been minimized.

Show comment
Hide comment
@Safihre

Safihre Feb 19, 2018

Contributor

Test package for NZBGet has been released: #3138.
We no longer compile it here on the repo, but fetch the latest official installer from NZBGet.
During package installation you can choose if you want the latest stable or testing release. After this you can use NZBGet's internal update system to do updates.
We hope to soon publish this on the official repo.

Contributor

Safihre commented Feb 19, 2018

Test package for NZBGet has been released: #3138.
We no longer compile it here on the repo, but fetch the latest official installer from NZBGet.
During package installation you can choose if you want the latest stable or testing release. After this you can use NZBGet's internal update system to do updates.
We hope to soon publish this on the official repo.

@Safihre Safihre closed this Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment