Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deploy constraint #18

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Nate-Wilkins
Copy link

commented Jul 30, 2016

Proposal for #17

Nate-Wilkins added some commits Jul 30, 2016

@Syntaf

This comment has been minimized.

Copy link
Owner

commented Aug 5, 2016

I still need to know why someone would need to change their output directory, can you give me a scenario where changing the target directory is actually needed?

The target dir really only holds temporary files. Sphinx generates output get to the target dir, then ghp-import copies that output from target dir into the gh-pages branch. I don't see any reason why someone should need to specify a different folder to an intermediate step of travis-sphinx to some other folder.

@Nate-Wilkins

This comment has been minimized.

Copy link
Author

commented Aug 6, 2016

The main reason that I'd like to change the output directory is so that I can build the docs using sphinx directly alongside travis-sphinx but in all reality I could just use travis-sphinx to build and deploy. I just need the ability to customize the options going into the build process or just use sphinx.

@Syntaf

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2016

That sounds like a needed feature then, ok.

In your PR however, you are now allowing the --source option to be used in deploy, but the source field is never used. I would revert this and allow the target dir only, then I can merge

@DavidLP

This comment has been minimized.

Copy link

commented Nov 13, 2016

I also would like to have this. Otherwise there is no way to use the github pages feature that expects the index.html in the docs folder. Thus I cannot use this package.

@Syntaf

This comment has been minimized.

Copy link
Owner

commented Nov 14, 2016

I can merge this once he made the fix I commented, though I can probably do the fix myself in a couple days.... this will be added within the week then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.