Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom deploy repo using GH_REPO_SLUG env variable #38

Merged
merged 1 commit into from May 6, 2018

Conversation

Projects
None yet
3 participants
@nocarryr
Copy link
Contributor

nocarryr commented May 4, 2018

This modification was needed for what may or may not be an typical use case, but I still wanted to share it in case it seemed useful.

I maintain a project that I am not the owner of and cannot directly make certain changes to (the project owner isn't always active and I try to respect that as much as possible). The docs are set up and hosted through my fork, so I needed a way to make build.py deploy there.

Relevant PR: https://github.com/roger-/pyrtlsdr/pull/82

I welcome your comments/suggestions, etc. If this isn't something you feel should be part of this project, I can just keep my fork up for my own purposes.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #38 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   81.48%   81.75%   +0.27%     
==========================================
  Files           5        5              
  Lines         135      137       +2     
==========================================
+ Hits          110      112       +2     
  Misses         25       25
Impacted Files Coverage Δ
travis_sphinx/deploy.py 94.87% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5984fef...e9df3ec. Read the comment docs.

@Syntaf

This comment has been minimized.

Copy link
Owner

Syntaf commented May 4, 2018

Thanks for the PR @nocarryr! I'll take a look when I get home and merge is ASAP

@Syntaf Syntaf merged commit d43ee0c into Syntaf:master May 6, 2018

3 checks passed

codecov/patch 100% of diff hit (target 81.48%)
Details
codecov/project 81.75% (+0.27%) compared to 5984fef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.