fix vault rewards module tests #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes boil down to: * using `evm_setNextBlockTimestamp` instead of just `fastForward` within `fastForwardTo`-- ensures exact timestamp is delivered * recognition that `evm_mine` always causse the block timestamp to incraese by 1 second, so we should be able to account for this in the test to get the exact time also btw the refactoring of these tests was not exactly the same as before, which is part of the reason why the tests were failing when they succeeded before
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 58 58
Lines 1044 1044
Branches 69 69
=======================================
Hits 1014 1014
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
noahlitvin
approved these changes
Sep 1, 2022
mjlescano
approved these changes
Sep 1, 2022
mjlescano
reviewed
Sep 1, 2022
| @@ -21,13 +21,9 @@ export async function fastForward(seconds: number, provider: ethers.providers.Js | |||
| } | |||
|
|
|||
| export async function fastForwardTo(time: number, provider: ethers.providers.JsonRpcProvider) { | |||
| const now = await getTime(provider); | |||
| await provider.send('evm_setNextBlockTimestamp', [time]); | |||
There was a problem hiding this comment.
Nice! didn't know about evm_setNextBlockTimestamp 👏
There was a problem hiding this comment.
these docs are very helpful https://book.getfoundry.sh/reference/anvil/?highlight=time#supported-rpc-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes boil down to:
evm_setNextBlockTimestampinstead of justfastForwardwithinfastForwardTo-- ensures exact timestamp is deliveredevm_minealways causse the block timestamp toincraese by 1 second, so we should be able to account for this in the test to get
the exact time
also btw the refactoring of these tests was not exactly the same as
before, which is part of the reason why the tests were failing when they
succeeded before