Feature: ONCE launch mode for clips - #1018
Merged
m-m-adams merged 17 commits intoJan 25, 2024
Merged
Conversation
soymonitus
marked this pull request as draft
January 19, 2024 09:12
Currently the clip loops and plays forever if: - Armed before deluge has started playing - You start playing it wih Shift + Arm
soymonitus
marked this pull request as ready for review
January 20, 2024 18:40
soymonitus
changed the title
Collaborator
Author
|
@m-m-adams @entzmingerc Ready for testing and review. Tested several edge cases and both Row and Grid modes. At worst it will have the same limitations as Fill clips, but I made sure it works as good as the Fill clips regarding instant launches, section launch launches, cloned clips, etc |
# Conflicts: # src/deluge/model/clip/clip.h # src/deluge/playback/mode/session.cpp
Collaborator
Author
|
Had to solve merge conflicts due to latest change of launchstyle to enum. |
# Conflicts: # docs/community_features.md # src/deluge/playback/mode/session.cpp
m-m-adams
reviewed
Jan 25, 2024
Collaborator
Author
|
@m-m-adams Answered all questions and applied patch from stellar-aria to improve menu items |
m-m-adams
approved these changes
Jan 25, 2024
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* Initial commit. Created all the enums and UI handling * Play clip once if set that way Currently the clip loops and plays forever if: - Armed before deluge has started playing - You start playing it wih Shift + Arm * Clip also plays once even when solo’ed * dbt format * undo this change. not necessary * Disable instant launch for ONCE clips * Fixed several edge cases * Update communituy documentation * Updated launchstyle option * Simplified if conditions * Simplify condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to FILL launch mode but starts at beat 1 and auto-mutes after playing once.
Tasks: