Add Mutable Reverb#1065
Merged
stellar-aria merged 10 commits intoJan 26, 2024
Merged
Conversation
stellar-aria
force-pushed
the
mutable-reverb
branch
from
aa4358b to
aa3878e
Compare
stellar-aria
force-pushed
the
mutable-reverb
branch
from
aa3878e to
6eac47b
Compare
Collaborator
|
The new reverb model is astonishing. Thanks a lot. |
seangoodvibes
requested changes
Jan 25, 2024
Collaborator
|
Small 'nit', in the global menu, the order is AMOUNT, MODEL, ROOM SIZE, while in the clip menu the order is MODEL, AMOUNT, ROOM SIZE. Could you make them consistent with each other? |
seangoodvibes
requested changes
Jan 25, 2024
stellar-aria
force-pushed
the
mutable-reverb
branch
from
ca5f71d to
f433bae
Compare
stellar-aria
force-pushed
the
mutable-reverb
branch
from
f433bae to
16790b4
Compare
seangoodvibes
approved these changes
Jan 25, 2024
Collaborator
seangoodvibes
left a comment
seangoodvibes
left a comment
There was a problem hiding this comment.
Thx for making the changes requested :)!
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* Add Mutable Reverb * Point to updated argon * Persist Reverb settings across model changes * Add reverb model menu to global reverb menu * Change model position in original menu * change to deluge::vector * Remove unnecessary setters * Change case of process method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #952