Enhancement / Automation View - Better Integration of Automation View with Menu System#1156
Merged
Conversation
seangoodvibes
changed the title
seangoodvibes
changed the title
Collaborator
|
Maybe that submenu should move to |
Collaborator
Author
@m-m-adams said we shouldn't nest the automation menu under UI and that it should be a top level default menu instead. As for not being able to access global settings, I did think about this. I think the right fix would be to re-instate shift + select to bring us into settings this would necessitate changing the interpolation shortcut which is a good idea anyway. I want to use shift + interpolation and blink the interpolation shortcut to indicate that interpolation is on. |
seangoodvibes
changed the title
seangoodvibes
marked this pull request as draft
February 3, 2024 21:05
Collaborator
|
That sounds good to me, I think.
…On Sat, Feb 3, 2024, 12:14 Sean Ditny ***@***.***> wrote:
Maybe that submenu should move to GLOBAL SETTINGS > DEFAULTS > UI >
AUTOMATION instead? Right now Automation View is the only place where you
can't access the global settings which feels odd.
@m-m-adams <https://github.com/m-m-adams> said we shouldn't nest the
automation menu under UI and that it should be a top level automation menu
instead.
As for not being able to access global settings, I did think about this.
I think the right fix would be to re-instate shift + select to bring us
into settings
and then just pressing on select encoder would open the automation menu
this would necessitate changing the interpolation shortcut which is a good
idea anyway. I want to use shift + interpolation and blink the
interpolation shortcut to indicate that interpolation is on.
—
Reply to this email directly, view it on GitHub
<#1156 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALRZ7DXAE5EABXIILHBW3DYR2LATAVCNFSM6AAAAABCVN66COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGQ2DIOJXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
from
February 10, 2024 02:31
12464d0 to
c291ef0
Compare
seangoodvibes
force-pushed
the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
2 times, most recently
from
February 13, 2024 00:16
1cc07bd to
1108118
Compare
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
from
February 13, 2024 00:16
1108118 to
d48204e
Compare
seangoodvibes
marked this pull request as ready for review
February 13, 2024 00:16
- added back the settings and sound menu's to automation view - allow you to jump from the sound menu's for a specific parameter straight into the automation editor for that parameter - move the interpolation shortcut to the interpolation pad in the first column - blink interpolation shortcut when interpolation is on - disable select parameter scrolling in automation view for non-midi clip automation - add adjustment of parameter values using select encoder - updated documentation
seangoodvibes
force-pushed
the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
from
February 13, 2024 00:20
cf45415 to
a6293f5
Compare
m-m-adams
reviewed
Feb 13, 2024
| PatchedParam() = default; | ||
| PatchedParam(int32_t newP) : Param(newP) {} | ||
| MenuItem* selectButtonPress(); | ||
| ActionResult buttonAction(deluge::hid::Button b, bool on) { return Param::buttonAction(b, on); } |
Collaborator
There was a problem hiding this comment.
I think this should just pass through inheritance?
Collaborator
Author
There was a problem hiding this comment.
I think this should just pass through inheritance?
I tried removing the three button action calls and it did not work anymore.
I treated it the same as the selectButtonAction function which is also added to all three of these classes which inherit param.
|
|
||
| uint8_t shouldDrawDotOnName() final { return PatchedParam::shouldDrawDotOnName(); } | ||
| MenuItem* selectButtonPress() final { return PatchedParam::selectButtonPress(); } | ||
| ActionResult buttonAction(deluge::hid::Button b, bool on) final { return PatchedParam::buttonAction(b, on); } |
| [[nodiscard]] int32_t getMaxValue() const override { return Param::getMaxValue(); } | ||
| [[nodiscard]] int32_t getMinValue() const override { return Param::getMinValue(); } | ||
| MenuItem* selectButtonPress() final { return Param::selectButtonPress(); } | ||
| ActionResult buttonAction(deluge::hid::Button b, bool on) final { return Param::buttonAction(b, on); } |
seangoodvibes
force-pushed
the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
from
February 13, 2024 01:30
9b4eaa9 to
9e90518
Compare
If you're already in automation view and you enter an automatable parameters menu, update the selected parameter in the root automation view UI and refresh the grid to show the automation for that parameter open in the menu.
m-m-adams
added this pull request to the merge queue
Feb 13, 2024
seangoodvibes
deleted the
Bugfix---Automation-View---Save-automation-menu-default-settings
branch
February 22, 2024 23:20
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
… with Menu System (SynthstromAudible#1156) * Better Integration of Automation View with Menu System - added back the settings and sound menu's to automation view - allow you to jump from the sound menu's for a specific parameter straight into the automation editor for that parameter - move the interpolation shortcut to the interpolation pad in the first column - blink interpolation shortcut when interpolation is on - disable select parameter scrolling in automation view for non-midi clip automation - add adjustment of parameter values using select encoder - updated documentation * document inheritance issue * Update clip minder check * Change automation view selection If you're already in automation view and you enter an automatable parameters menu, update the selected parameter in the root automation view UI and refresh the grid to show the automation for that parameter open in the menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will: