Feature / Transpose Chromatically All Scale Mode Instrument Clips (excl. Kits) from Song View's (Song / Arranger / Arranger Automation / Performance)#1159
Merged
Conversation
seangoodvibes
force-pushed
the
Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
branch
from
efa1911 to
d7da642
Compare
seangoodvibes
changed the title
Contributor
|
Beautiful! Ideas for the future, based on this:
Just some brainstorming here, the new shortcut is definitely great on it's own, even more so as it is super-consistent with current behaviour! |
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
branch
from
5bfbea7 to
1a0e96c
Compare
Collaborator
|
When transposing.. say 1 semitone, will this just change root note and not scale? I mean, if you have your clips in C Major scale, and you turn up 1 notch, will the scale now be C# major? |
Collaborator
Author
Correct this does not change the scale. It changes the root note (eg C major to C# major). |
…anger / Arranger Automation / Performance) Added ability to transpose all scale mode clips from all the various song views (Song Row/Grid, Arranger, Arranger Automation, Performance View)
Add documentation
Refactored transposition code to Song:: Added functions to display total transposed semitones Added functions to adjust and display master transpose offset
Pressing a clip and engaging transpose gives the impression you are changing only that clip's transpose, which is not the case. Handle this by making sure there is no active UI mode before engaging transpose in song view and arranger view
Ignore kit clips in the clip traversing loop
Adjusted documentation to clarify the type of transpose in this feature.
Removed display of # of semitones transposed Added display of current root note and scale Added pop up to instrument clip view, automation view, song view, performance view and arranger view when you press down on the vertical encoder to display the current root note and scale For an instrument clip, it only displays the current root note and scale popup if it's a scale mode clip
…nthstromAudible#1180) * Add menu name/title changes on Mutable reverb; change "Dampening" * Revert dampening/damping for storageManager (xml reading) * format
seangoodvibes
force-pushed
the
Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
branch
from
d257250 to
8ace960
Compare
…anger / Arranger Automation / Performance) Added ability to transpose all scale mode clips from all the various song views (Song Row/Grid, Arranger, Arranger Automation, Performance View)
Add documentation
Refactored transposition code to Song:: Added functions to display total transposed semitones Added functions to adjust and display master transpose offset
Pressing a clip and engaging transpose gives the impression you are changing only that clip's transpose, which is not the case. Handle this by making sure there is no active UI mode before engaging transpose in song view and arranger view
Ignore kit clips in the clip traversing loop
Adjusted documentation to clarify the type of transpose in this feature.
Removed display of # of semitones transposed Added display of current root note and scale Added pop up to instrument clip view, automation view, song view, performance view and arranger view when you press down on the vertical encoder to display the current root note and scale For an instrument clip, it only displays the current root note and scale popup if it's a scale mode clip
m-m-adams
force-pushed
the
Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
branch
from
8ace960 to
f34a091
Compare
m-m-adams
reviewed
Feb 7, 2024
Collaborator
m-m-adams
left a comment
m-m-adams
left a comment
There was a problem hiding this comment.
Looks good! One UI nit
…'s-(Song-/-Arranger-/-Arranger-Automation-/-Performance)' of https://github.com/seangoodvibes/DelugeFirmware into Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
m-m-adams
approved these changes
Feb 7, 2024
seangoodvibes
deleted the
Feature-/-Transpose-All-Scale-Mode-Clips-from-Song-View's-(Song-/-Arranger-/-Arranger-Automation-/-Performance)
branch
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…cl. Kits) from Song View's (Song / Arranger / Arranger Automation / Performance) (SynthstromAudible#1159) * Feature / Transpose All Scale Mode Clips from Song View's (Song / Arranger / Arranger Automation / Performance) Added ability to transpose all scale mode clips from all the various song views (Song Row/Grid, Arranger, Arranger Automation, Performance View) * Update documentation Add documentation * Allow customizable transpose offset Refactored transposition code to Song:: Added functions to display total transposed semitones Added functions to adjust and display master transpose offset * Don't engage master transpose if clip is selected Pressing a clip and engaging transpose gives the impression you are changing only that clip's transpose, which is not the case. Handle this by making sure there is no active UI mode before engaging transpose in song view and arranger view * Remove Scale Mode Clip Restriction * Update documentation * Ignore Kit Clips Ignore kit clips in the clip traversing loop * Restrict transpose to scale mode clips * Define transpose as Chromatic Transpose Adjusted documentation to clarify the type of transpose in this feature. * Display Root Note and Scale Removed display of # of semitones transposed Added display of current root note and scale Added pop up to instrument clip view, automation view, song view, performance view and arranger view when you press down on the vertical encoder to display the current root note and scale For an instrument clip, it only displays the current root note and scale popup if it's a scale mode clip * Add menu name/title changes on Mutable reverb; change "Dampening" (SynthstromAudible#1180) * Add menu name/title changes on Mutable reverb; change "Dampening" * Revert dampening/damping for storageManager (xml reading) * format * Mention volume fix in changelog (SynthstromAudible#1181) * Feature / Transpose All Scale Mode Clips from Song View's (Song / Arranger / Arranger Automation / Performance) Added ability to transpose all scale mode clips from all the various song views (Song Row/Grid, Arranger, Arranger Automation, Performance View) * Update documentation Add documentation * Allow customizable transpose offset Refactored transposition code to Song:: Added functions to display total transposed semitones Added functions to adjust and display master transpose offset * Don't engage master transpose if clip is selected Pressing a clip and engaging transpose gives the impression you are changing only that clip's transpose, which is not the case. Handle this by making sure there is no active UI mode before engaging transpose in song view and arranger view * Remove Scale Mode Clip Restriction * Update documentation * Ignore Kit Clips Ignore kit clips in the clip traversing loop * Restrict transpose to scale mode clips * Define transpose as Chromatic Transpose Adjusted documentation to clarify the type of transpose in this feature. * Display Root Note and Scale Removed display of # of semitones transposed Added display of current root note and scale Added pop up to instrument clip view, automation view, song view, performance view and arranger view when you press down on the vertical encoder to display the current root note and scale For an instrument clip, it only displays the current root note and scale popup if it's a scale mode clip * Change Offset to Interval per Feedback --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> Co-authored-by: Mark Adams <mark.adams@queensu.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to chromatically transpose all scale mode instrument clips (excluding kits) from all the various song views (Song Row/Grid, Arranger, Arranger Automation, Performance View)
Uses the same shortcut as when you're in a Synth/Midi/CV clip (Press and turn <>) to transpose the clips chromatically by +/- # of semitones (customizable, see below)
The display will show you the current root note and scale (before and after transposition):
You can adjust the number of semitones offset that the master transpose will transpose clips by, by holding shift and turning <>. The display will show you the transpose offset.