Feature/Per clip compressors#1173
Merged
m-m-adams merged 17 commits intoFeb 6, 2024
Merged
Conversation
Co-authored-by: Reed Koser <srkoser+GitHub@gmail.com>
m-m-adams
force-pushed
the
feature/render_clip_compressors
branch
from
456901e to
360c9dd
Compare
finish comment remove meter from comp threshold mod knob swap if else format
m-m-adams
force-pushed
the
feature/render_clip_compressors
branch
from
360c9dd to
0f49960
Compare
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* move volume increment calculation into processReverbSendAndVolume * track previous volume in processReverbSendAndVolume * render compressors on synth and kit outputs * make threshold a param * timeout skipping rendering if compressor hasn't fully released * menu for threshold * fix render location for sounds * improve compressor volume scaling to be closer to un compressed volume * add menus for controlling remaining compressor values * get volume adjustment even closer, bypass when not rendered * fix up strings for clarity * Update src/deluge/processing/sound/sound.cpp Co-authored-by: Reed Koser <srkoser+GitHub@gmail.com> * Address review comments: finish comment remove meter from comp threshold mod knob swap if else format * add documentation * add link to compresors section of community features * move it under the added reverb line * remove the link --------- Co-authored-by: Reed Koser <srkoser+GitHub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a compressor to every synth, kit, and kit row. The compressor can be edited from the menu for each sound, and threshold is implemented as an unpatched param, so it can be learnt to a gold knob and automated. The other params could be moved as well but I'm not confident that they would be useful to automate.
Also tweaks make up gain on the compressor to more closely match non-compressed value - otherwise the switch from bypassed to active wasn't feasible
Performance impact is minimal - I don't notice a difference on the stress test while bypassed. When the compressors are active, each compressor (1 per instrument + 1 per kit row) costs about half of a voice
Closes #951