Sticky keys

[sapphire-arches]

Fixes #107

TODO:

• Long press enable mode
• Illuminate shift when it's stuck on by sticky keys
• Audit the various test modes to make sure they will work with stickykeys (either by disabling it or adding appropriate calls to the shift mode code)
• Custom UI class for the sticky keys menu (7seg compat + long press enable/time configuration)
• Add audible indication when sticky keys enabled (if it's easy, this is a very silly feature)

[sapphire-arches]

I'm probably not going to implement the sound notification, as funny as it would be. I don't have the MIDI hardware to test CC learning either, so I'll leave that for a followup.

[sapphire-arches]

Known bug: if you disable sticky keys with the shift key in sticky mode, it'll stay in sticky mode until a reset.

[jamiefaye]

Please fix the conflicts and we can merge it in.

[sapphire-arches]

I still haven't fixed the bug above, got very sidetracked trying to understand the menu system better

…

On Mon, Jul 3, 2023, 12:17 Jamie Fenton ***@***.***> wrote: Please fix the conflicts and we can merge it in. — Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALRZ7AKTIC37ZAMVOWQZPDXOMLDVANCNFSM6AAAAAAZXWOYCY> . You are receiving this because you were assigned.Message ID: ***@***.***>

[jamiefaye]

Waiting here for conflicts to be resolved.

[wtkdwc]

hi, just an thought (no clue about implementation) - wouldn't be more practical the opposite behavior of turning sticky on? like on novation circuit menus - one very short press/click turns on sticky shift and holding longer was standard behavior. that way you would avoid mentioned accidental turning it on or having to wait longer times to turn it on.

[PaulFreund]

Hey, a quick heads up :) After two weeks without any activity from the author of a PR we tag it with the "stale" label and close it after another week of inactivity as per our Contributor guidelins. This is not to create pressure or discourage anyone but to keep the list of Pull requests maintainable.

We are very happy about your contribution and nothing will be lost. You can pick up the work at any time by reopening the PR or creating a new one.

[sapphire-arches]

Thanks for the idea @wtkdwc, I've implemented it exactly that way. When sticky shift is on, a short press will stick shift on, unless you also press another button during the short press (we assume that means you wanted to just quickly enter a combo). Short press again will disable it.

[sdesign75]

In clip view you can’t audition notes when sticky shift is enabled. Is there a way to still audition notes so I can hear my patch while using shortcuts to edit the sound parameters?

[duncanrmi]

crashes my machine before I can even exit the settings menu. :-(

[sapphire-arches]

@sdesign75 today there is not, we probably should have a way to do it.

[sapphire-arches]

@duncanrmi please open a new issue with a description of exactly what you were doing when the device crashed.

[duncanrmi]

I did- it’s here, though I note with regret that the ’shift’ function isn’t in the title…. "deluge community build A77E2DE hard crash in settings menu #685" On 6 Nov 2023, at 18:45, Reed Koser ***@***.***> wrote: @duncanrmi <https://github.com/duncanrmi> please open a new issue with a description of exactly what you were doing when the device crashed. — Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDYETCW2Q5YGLVJ2BQF4H6DYDEV6PAVCNFSM6AAAAAAZXWOYC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVHEYTCOBXGI>. You are receiving this because you were mentioned.