Implemented transpose in scale for Shift + hold and turn vertical encoder - #1183
Merged
m-m-adams merged 8 commits intoFeb 7, 2024
Merged
Conversation
Collaborator
Author
|
@m-m-adams @seangoodvibes this is ready for testing! |
Collaborator
Author
|
I made some changes after looking at the code @0beron is writing for his PR, to avoid future conflicts between the two PRs. The features are now clearly differentiated. He can still make use of the instrumentClip's transpose() method while I use a new one called nudgeNotesVertically |
m-m-adams
approved these changes
Feb 7, 2024
m-m-adams
added this pull request to the merge queue
Feb 7, 2024
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…oder (SynthstromAudible#1183) * Implemented transpose in scale for Shift + hold and turn vertical encoder * Format * Docs * Take the nudge vertical to a new function so tranpose by semitones is still available * Fix compile issue * Fix compile issue * Damn dbt format * Added comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1179
Now the command "Shift + hold and turn vertical encoder" inside a clip instead of transposing all clips in the song, it will nudge notes vertically according to the mode the clip is in (scale or non-scale).
If in scale, the notes are nudged vertically respecting the scale.
If clip not in scale mode, the notes are nudged by semitones.
Colors of the audition pads and notes are updated (they were not before).
The existing command "Hold and turn vertical encoder" keeps working as always, that is, transposing an octave all notes for this clip.