Arpeggiator improvements by soymonitus · Pull Request #1198 · SynthstromAudible/DelugeFirmware

soymonitus · 2024-02-09T09:10:06Z

Added new features to the arpeggiator (Note: Ratchets are currently available only for Synth clips, but expected to be
extended to Midi clips and Kit rows in the future). The new features include:
1. Splitted the old Mode setting into separate settings Mode (Off or Arpeggiator) Octave Mode (Up, Down,
Up&Down, Alternate or Random) and Note Mode (Up, Down, Up&Down, AsPlayed or Random) settings, so you can setup
individually how octaves are walked and how notes are walked in the sequence.
2. The Mode pad shortcut is now an Arp preset shortcut, which will update the new 3 settings all at once:
- Off will disable arpeggiator.
- Up will setup Mode to Arpeggiator, Octave Mode to Up and Note Mode to Up.
- Down will setup Mode to Arpeggiator, Octave Mode to Down and Note Mode to Down.
- Both will setup Mode to Arpeggiator, Octave Mode to Alternate and Note Mode to Up.
- Random will setup Mode to Arpeggiator, Octave Mode to Random and Note Mode to Random.
- Custom will setup Mode to Arpeggiator, and enter a submenu to let you edit Octave Mode and Note Mode.
3. Mode (MODE):
- Off disables the arpeggiator.
- Arpeggiator (ARP) enables the arpeggiator.
4. Octave Modes (OMOD):
- Up (UP) will walk the octaves up.
- Down (DOWN) will walk the octaves down.
- Up & Down (UPDN) will walk the octaves up and down, repeating the highest and lowest octaves.
- Alternate (ALT) will walk the octaves up, and then down reversing the Notes pattern (without
repeating notes). Tip: Octave Mode set to Alternate and Note Mode set to Up is equivalent to
the old Both mode.
- Random (RAND) will choose a random octave every time the Notes pattern has played.
Tip: Set also Note Mode to Random to have the equivalent to the old Random mode.
5. Note Modes (NMOD):
- Up (UP) will walk the notes up.
- Down (DOWN) will walk the notes down. Tip: this mode also works in conjunction with Octave Mode
Alternate, which will walk all the notes and octaves all the way down, and then up reversing it.
- Up & Down (UPDN) will walk the notes up and down, repeating the highest and lowest notes.
- As played (PLAY) will walk the notes in the same order that they were played. Tip: this mode
also works in conjunction with Octave Mode Alternate, which will walk all the notes and octaves
all the way up (with notes as played), and then down reversing the order of played notes.
- Random (RAND) will choose a random note each time. If the Octave Mode is set to something
different than Random, then the pattern will play, in the same octave, the same number of random
notes as notes are in the held chord and then move to a different scale based on the Octave Mode.
Tip: Set also Octave Mode to Random to have the equivalent to the old Random mode.
6. Sequence Length (LENG) (unpatchet parameter, assignable to golden knobs):
- If set to zero, the arpeggiator pattern will play fully.
- If set to a value higher than zero, the pattern will play up to the set number of notes, and then
reset itself to start from the beginning.
7. Ratcheting: There are two new parameters (unpatched, assignable to golden knobs), to control how notes
are ratcheted. A ratchet is when a note repeats itself several time in the same time interval that the
original note has to play.
- Ratchet Amount (RATC): this will set the maximum number of ratchets that an arpeggiator step
could have (each step will randomize the number of ratchet notes between 1 and max value).
- From values 0 to 4, no ratchet notes
- From 5 to 19, up to 2 ratchet notes
- From 20 to 34, up to 4 ratchet notes
- From 35 to 50, up to 8 ratchet notes
- Ratchet Probability (RPRO): this sets how likely a step is to be ratcheted
- Being 0 (0%), no ratchets at all
- And 50 (100%), all notes will evaluate to be ratcheted.

Follow-up ideas/improvements for later (out of scope for this PR):

Rhythm (rests patterns), like the ones in Novation Launchkey: 0, 0x0, 0xx0, Random
Add "Chord" to Note Mode (to play all notes at the same time)
Ratchets for kit rows and midi clips
Sequencer (16 configurable steps with +- deviation in semitones from held note)

# Conflicts: # src/deluge/gui/views/automation_view.cpp

…nteresting patterns

m-m-adams · 2024-02-19T00:36:11Z

The arpeggiator mode pad is a waste now - could you make it work like unison, where pressing once does note direction (starting from off) and pressing a second time does octave direction?

sapphire-arches · 2024-02-19T00:02:13Z

+		return ArpOctaveMode::UP;
+	}
+}
+


These can/should be replaced with EnumStringMap I think, should provide some code size savings (see src/deluge/model/mod_controllable/filters/filter_config.cpp for an example of how to use these). They can live in arpeggiator.cpp as static functions too, so functions.cpp doesn't expand forever.

I specify different names for OLED and 7SEG so probably not a good fit this EnumStringMap

I'm working on converting params to use the enumStringMap as a bigger refactor, don't worry about it for now

sapphire-arches · 2024-02-19T00:10:01Z

+#include "gui/menu_item/unpatched_param.h"
+#include "gui/ui/sound_editor.h"
+
+namespace deluge::gui::menu_item::arpeggiator {


Instead of 3 separate classes, this, RatchetProbability, and SequenceLength could be a single class deluge:gui::menu_item::unpatched_param::Arpeggiator (in deluge/gui/menu_item/unpatched_param).

but they are different parameters, how are they supposed to be the same class?

The specific parameter to edit is a constructor parameter.

I see other params inheriting from public UnpatchedParam and they are in different folders and classes. I think I don't understand what you mean

All three of these classes are identical (you're just over riding isRelevant) and the param id is passed in the constructor

sapphire-arches · 2024-02-19T00:15:09Z

 			uint32_t gateThreshold = activeInstrumentClip->arpeggiatorGate + 2147483648;
+			uint32_t ratchetProbability = activeInstrumentClip->arpeggiatorRatchetProbability + 2147483648;
+			uint32_t ratchetAmount = activeInstrumentClip->arpeggiatorRatchetAmount + 2147483648;
+			uint32_t sequenceLength =
+			    (((int64_t)activeInstrumentClip->arpeggiatorSequenceLength + 2147483648) * kMaxMenuValue + 2147483648)
+			    >> 32;


Suggested change

uint32_t gateThreshold = activeInstrumentClip->arpeggiatorGate + 2147483648;

uint32_t ratchetProbability = activeInstrumentClip->arpeggiatorRatchetProbability + 2147483648;

uint32_t ratchetAmount = activeInstrumentClip->arpeggiatorRatchetAmount + 2147483648;

uint32_t sequenceLength =

(((int64_t)activeInstrumentClip->arpeggiatorSequenceLength + 2147483648) * kMaxMenuValue + 2147483648)

>> 32;

uint32_t gateThreshold = activeInstrumentClip->arpeggiatorGate + 2147483648U;

uint32_t ratchetProbability = activeInstrumentClip->arpeggiatorRatchetProbability + 2147483648U;

uint32_t ratchetAmount = activeInstrumentClip->arpeggiatorRatchetAmount + 2147483648U;

uint32_t sequenceLength =

(((int64_t)activeInstrumentClip->arpeggiatorSequenceLength + 2147483648) * kMaxMenuValue + 2147483648U)

>> 32;

I think these calculations can overflow otherwise? It's unclear how gateThreshold was working before.

The gateThreshold line has been like that from the beginnings so I just did the same with my new parameters. I haven't experienced any buggy behavior even setting parameter values from minimum to maximum values

…sequence

…e to notemode

soymonitus · 2024-02-19T12:40:44Z

@sapphire-arches I pushed some changes for some comments of your feedback

- Have the ratcheted step include the possibility to have no ratchets, so even at 100% probability we still get steps with no ratchets - Crash on new song when accessing Preset modes (pad shortcut) - Make ratchet notes not increment sequence index

m-m-adams · 2024-02-19T19:09:41Z

@sapphire-arches I'm merging and opening an issue with the minor tweaks needed - I want user feedback on this

* Initial commit * Work in progress * Fixed bug * Changed labels * Refactor ratchet chance to ratchet probability * Disable arp ratchets for drums * Change param name * Fix param reading * Format * wip * Added octave mode direction parameter do add more options to create interesting patterns * New params (wip) * lots of improvements * Disable ratchets for midi clips for now.. * Fix compile * Removed unused menu option * Hack to disable midi clips ratcheting till i fix the gate issue * format * Add flag so when settings change, force a restart of the arpeggiator sequence * Added PresetMode and now CUSTOM takes you to octavemode and octavemode to notemode * format * Format * Refactor * Updated docs * updated doc * Feedback from sapphire-arches * Misc bugfixing - Have the ratcheted step include the possibility to have no ratchets, so even at 100% probability we still get steps with no ratchets - Crash on new song when accessing Preset modes (pad shortcut) - Make ratchet notes not increment sequence index * Missing param * Fixed bug: new ratchet params not able to be learned to golden knobs * Enable “Sequence Length” for kit rows and update docs * Fixed Sequence Length for arpeggios of 1 note * Better arp menu order * Updated Docs

Initial commit

0d1125b

soymonitus marked this pull request as draft February 9, 2024 09:10

soymonitus added 6 commits February 9, 2024 19:51

Merge branch 'community' into monitus/arpeggiator_improvements

29a1c9c

Work in progress

19c3ad1

Merge branch 'community' into monitus/arpeggiator_improvements

5679c52

Fixed bug

fe65540

Changed labels

3414cf5

Refactor ratchet chance to ratchet probability

7f59839

m-m-adams reviewed Feb 12, 2024

View reviewed changes

Comment thread src/deluge/processing/sound/sound.cpp Outdated

m-m-adams reviewed Feb 12, 2024

View reviewed changes

Comment thread src/deluge/processing/sound/sound.cpp Outdated

soymonitus added 18 commits February 13, 2024 00:26

Disable arp ratchets for drums

e866b21

Change param name

7e5565e

Fix param reading

19b8bca

Format

64bd335

Merge branch 'community' into monitus/arpeggiator_improvements

ea8cb13

Merge branch 'community' into monitus/arpeggiator_improvements

80de027

# Conflicts: # src/deluge/gui/views/automation_view.cpp

wip

b71cc6f

Added octave mode direction parameter do add more options to create i…

f1b2f07

…nteresting patterns

Merge branch 'community' into monitus/arpeggiator_improvements

6379348

New params (wip)

948ab9e

Merge branch 'community' into monitus/arpeggiator_improvements

e953a03

Merge branch 'community' into monitus/arpeggiator_improvements

4f2ba79

Merge branch 'community' into monitus/arpeggiator_improvements

9a6fb16

Merge branch 'community' into monitus/arpeggiator_improvements

80356d9

lots of improvements

4f66b29

Disable ratchets for midi clips for now..

07d815e

Fix compile

7be7e21

Removed unused menu option

930823f

Hack to disable midi clips ratcheting till i fix the gate issue

3499f4c

format

88459e2

sapphire-arches reviewed Feb 19, 2024

View reviewed changes

soymonitus added 8 commits February 19, 2024 11:32

Add flag so when settings change, force a restart of the arpeggiator …

795d861

…sequence

Added PresetMode and now CUSTOM takes you to octavemode and octavemod…

b96088f

…e to notemode

format

6a30e6d

Format

552420b

Refactor

c36268f

Updated docs

a300a01

updated doc

7876752

Feedback from sapphire-arches

4d9a3de

soymonitus marked this pull request as ready for review February 19, 2024 12:41

soymonitus changed the title ~~[Draft] Arpeggiator improvements~~ Arpeggiator improvements Feb 19, 2024

soymonitus added 7 commits February 19, 2024 16:08

Misc bugfixing

f5fa373

- Have the ratcheted step include the possibility to have no ratchets, so even at 100% probability we still get steps with no ratchets - Crash on new song when accessing Preset modes (pad shortcut) - Make ratchet notes not increment sequence index

Missing param

7c13c9a

Fixed bug: new ratchet params not able to be learned to golden knobs

22989c2

Enable “Sequence Length” for kit rows and update docs

6ab7518

Fixed Sequence Length for arpeggios of 1 note

f583d02

Better arp menu order

12e6b22

Updated Docs

954a1be

m-m-adams added the cherry-pick Commit to cherry pick to release branch label Feb 19, 2024

m-m-adams approved these changes Feb 19, 2024

View reviewed changes

m-m-adams added this pull request to the merge queue Feb 19, 2024

Merged via the queue into SynthstromAudible:community with commit 019f9fd Feb 19, 2024

soymonitus deleted the monitus/arpeggiator_improvements branch February 20, 2024 15:58

Uh oh!

Uh oh!

Conversation

soymonitus commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m-m-adams commented Feb 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

soymonitus commented Feb 19, 2024

Uh oh!

m-m-adams commented Feb 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

soymonitus commented Feb 9, 2024 •

edited

Loading