Skip to content

Feature/learn midi for kit#1251

Merged
seangoodvibes merged 13 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/learn_midi_for_kit
Feb 18, 2024
Merged

Feature/learn midi for kit#1251
seangoodvibes merged 13 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/learn_midi_for_kit

Conversation

@m-m-adams

@m-m-adams m-m-adams commented Feb 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Allows a whole kit to be learned at once to a midi channel. It's only possible from session/arranger view as I don't have a good UI for clip view

Todo:

  • Modify midi learn to work with Instrument* instead of MelodicInstrument*
  • Modify session view midi learning so that it can be used on all instruments
  • Map learned input into the kit, using the note/cc/aftertouch/pitch received for kit functions
  • Make it flash in session view

@m-m-adams m-m-adams marked this pull request as ready for review February 18, 2024 05:41
@sichtbeton

sichtbeton commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

oh this is great.

@m-m-adams m-m-adams force-pushed the feature/learn_midi_for_kit branch from d5d0384 to 43daf4d Compare February 18, 2024 17:01
@seangoodvibes seangoodvibes added this pull request to the merge queue Feb 18, 2024
Merged via the queue into SynthstromAudible:community with commit 212edb3 Feb 18, 2024
@m-m-adams m-m-adams deleted the feature/learn_midi_for_kit branch February 27, 2024 18:46
@entzmingerc entzmingerc mentioned this pull request May 2, 2024
Closed
tastycode pushed a commit to tastycode/DelugeFirmware that referenced this pull request Jul 3, 2024
@m-m-adams @tastycode
Feature/learn midi for kit (SynthstromAudible#1251)
2c3553c 
* move learned midi to instrument, rename usages

* enable learning for kit from session view

* clean up kit received midi functions

* make notes work

* add support for aftertouch, cc, pitch bend

* make flashing work properly

* make grid work too

* format

* support learning kit in arranger view

* learn root note for kit

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seangoodvibes seangoodvibes seangoodvibes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-m-adams @sichtbeton @seangoodvibes