#REQUEST 902 - Automatically load the last open/saved song or user-defined template at startup - #1272
Conversation
|
For formatting you can run ./dbt format to get the exact format config used by our CI If you're using VSCode and install the advanced formatters extension (should be in our suggested extensions) it'll do it on save for you |
Thanks Mark, i didn't know that, just run dbt format and checked in |
|
updated PR following shapphire-arches comments |
|
When booting the Deluge in the default template song.. when wanting to save the song it will show name "DEFAULT 2". It would be better if the Default song, when loaded, its name or file path is wiped, so it behaves like a blank song, where clicking Save will show you the next available song slot. Say your last song is named SONG34.xml, then the Deluge should suggest you the name "SONG35" |
soymonitus
left a comment
soymonitus
left a comment
There was a problem hiding this comment.
A change to make the Template feature work as intended
|
It doesn't work with booting from songs loaded/saved inside a subfolder. Dir name or path should also be taken into account. |
Good catch I'll write the subfolder support tonight hk time thx for the review |
|
Now it looks good. But i have no permissions to approve so an admin dev should take a look at it 😀 |
|
@joxihan could you add documentation for this feature to these documents please?
I would recommend added section 3.12 to the document under Section 3. General Improvements
Add a brief description of your change under section c1.2.0 Thanks! |
…at startup. - minor adaptation + documentation
joxihan
changed the title
Documentation added :) |
…at startup. - minor changes
…at startup. - minor fix
…at startup. - minor changes #9
sapphire-arches
left a comment
sapphire-arches
left a comment
There was a problem hiding this comment.
LGTM - I think we should add some safety check so if the default song load crashes we fall back to an init song, but that can be future work. Thanks for the contribution!
sapphire-arches
added
cherry-pick
Thanks, really my pleasure. I did some sanity check it seems to fallback pretty well in case of issue loading the song, (non existing or faulty file). |
Merging now :)! Welcome to the team :D |
…fined template at startup (SynthstromAudible#1272) * On power on, automatically load the last open/saved song or template * On power on, automatically load the last open/saved song or template - fix format * On power on, automatically load the last open/saved song or template - fix format - minor changes * On power on, automatically load the last open/saved song or template - following requested rework * On power on, automatically load the last open/saved song or template - minor changes * Automatically load the last open/saved song or user-defined template at startup. - minor adaptation + documentation * Update community_features.md * Automatically load the last open/saved song or user-defined template at startup. - minor changes * Automatically load the last open/saved song or user-defined template at startup. - minor fix * Automatically load the last open/saved song or user-defined template at startup. - minor changes SynthstromAudible#9 * fix build * fix format * Shorten 7seg string --------- Co-authored-by: Reed Koser <srkoser+GitHub@gmail.com>
5 participants
NEW SONG : Same behavior as current firmware, boot up on blank song.
TEMPLATE SONG: The current default behavior where a new project is initialized for you.
LAST USED SONG: The last project you loaded on the Deluge.
LAST MODIFIED SONG: The last project you saved on the Deluge.