Add Automation View for Patch Cables / Modulation Depth#1374
Merged
seangoodvibes merged 5 commits intoFeb 29, 2024
Merged
Conversation
Added ability to jump from the Sound menu for Patch Cables / Modulation Depth into automation view. For patch cables / modulation depth, the grid value ranges for each pad have been adapted to accomodate the full -50 to +50 range. The bottom pad in the grid will set the value to -50 and the top pad in the grid will set the value to +50. You can set the value to 0 by pressing and holding the two middle pads. The LED indicators for the mod encoders have been updated to show the full -50 to +50 range as well.
Contributor
seangoodvibes
force-pushed
the
Enter-Automation-View-for-Patch-Cable
branch
from
February 29, 2024 00:55
e0ec9ba to
1fc4c86
Compare
seangoodvibes
force-pushed
the
Enter-Automation-View-for-Patch-Cable
branch
from
February 29, 2024 00:55
b034d5a to
7d942a3
Compare
m-m-adams
reviewed
Feb 29, 2024
| // if you're dealing with a patch cable which has a -128 to +128 range | ||
| // we'll need to convert it to a 0 - 128 range for purpose of rendering on knob indicators | ||
| if (!onArrangerView && (getCurrentClip()->lastSelectedParamKind == params::Kind::PATCH_CABLE)) { | ||
| float floatKnobPos = kMaxKnobPos * ((static_cast<float>(knobPos) + kMaxKnobPos) / (kMaxKnobPos * 2)); |
Collaborator
There was a problem hiding this comment.
Ideally they'd show bipolar, maybe negative values fill in from the top.
Currently this doesn't match the display of learning gold knobs to patch cables either (which is positive only). I think they need to match either way - so only positives in automation right now, or display it bipolar with negatives coming down, or fix both
Collaborator
Author
There was a problem hiding this comment.
I will be fixing both so that the gold knobs outside automation view are bipolar as well. Thought it would be best to do that in a separate PR. It should be bipolar so that the middle of the LED indicators is 0, just like with pan.
m-m-adams
approved these changes
Feb 29, 2024
seangoodvibes
enabled auto-merge
February 29, 2024 01:15
seangoodvibes
added this pull request to the merge queue
Feb 29, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Add Automation View for Patch Cables / Modulation Depth Added ability to jump from the Sound menu for Patch Cables / Modulation Depth into automation view. For patch cables / modulation depth, the grid value ranges for each pad have been adapted to accomodate the full -50 to +50 range. The bottom pad in the grid will set the value to -50 and the top pad in the grid will set the value to +50. You can set the value to 0 by pressing and holding the two middle pads. The LED indicators for the mod encoders have been updated to show the full -50 to +50 range as well. * Update automation_view.md * Update documentation * Add PR link * Cleanup
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…dible#1374) * Add Automation View for Patch Cables / Modulation Depth Added ability to jump from the Sound menu for Patch Cables / Modulation Depth into automation view. For patch cables / modulation depth, the grid value ranges for each pad have been adapted to accomodate the full -50 to +50 range. The bottom pad in the grid will set the value to -50 and the top pad in the grid will set the value to +50. You can set the value to 0 by pressing and holding the two middle pads. The LED indicators for the mod encoders have been updated to show the full -50 to +50 range as well. * Update automation_view.md * Update documentation * Add PR link * Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to jump from the Sound menu for Patch Cables / Modulation Depth into automation view.
For patch cables / modulation depth, the grid value ranges for each pad have been adapted to accomodate the full -50 to +50 range.
The bottom pad in the grid will set the value to -50 and the top pad in the grid will set the value to +50.
You can set the value to 0 by pressing and holding the two middle pads.
The LED indicators for the mod encoders have been updated to show the full -50 to +50 range as well.
This diagram shows the updated value ranges for the pads when automating a patch cable / modulation depth.