Feature/midi save load#1390
Merged
stellar-aria merged 6 commits intoMar 2, 2024
Merged
Conversation
Contributor
alifeinbinary
approved these changes
Mar 1, 2024
alifeinbinary
left a comment
alifeinbinary
left a comment
Contributor
There was a problem hiding this comment.
Ran this PR on my OLED Deluge and was able to Load and Save presets by pressing load+MIDI and save+MIDI respectively. Presets appeared in the newly created ./MIDI directory with XML files with the names I had assigned to the presets.
stellar-aria
approved these changes
Mar 2, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
* save midi presets * basic midi preset loading * stop oob access on non existent midi backup * show load midi as title * refactor to have storage manager handle loading * save channel
stellar-aria
pushed a commit
that referenced
this pull request
Mar 2, 2024
* save midi presets * basic midi preset loading * stop oob access on non existent midi backup * show load midi as title * refactor to have storage manager handle loading * save channel
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* save midi presets * basic midi preset loading * stop oob access on non existent midi backup * show load midi as title * refactor to have storage manager handle loading * save channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows saving and loading midi presets. They end up in a new folder named MIDI
It only saves the items which would be saved in a song at the moment