Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params by seangoodvibes · Pull Request #1456 · SynthstromAudible/DelugeFirmware

seangoodvibes · 2024-03-09T04:07:45Z

Description:

Added "temporary" in-between automation editor layer to be able to edit params using the automation view editor UI without having to enter the full automation view UI to do it. When you're done editing and exit the menu, you are returned the previous UI you were in prior to entering the menu
Added back select encoder scrolling of automation view parameters while in the full automation view UI
Updated documentation

Some additional full automation view UI fine tuning:

When using the full automation view UI and entering the menu, the background UI will reset to the automation overview when first entering the menu and when you are not in a parameter menu
When using the full automation view UI, also enable editing the automation editor directly from the menu as users will come to expect this when using the in-between-UI. It also just makes sense.

Did some refactoring:

Refactored Param::selectButtonAction and PatchCableStrength::selectButtonAction to call Automation::selectButtonAction
Refactored Param::buttonAction and PatchCableStrength::buttonAction to call Automation::buttonAction
Refactored Param::selectAutomationViewParameter and PatchCableStrength::selectAutomationViewParameter to call Automation::selectAutomationViewParameter
Refactored Param::horizontalEncoderAction and PatchCableStrength::horizontalEncoderAction to call Automation::horizontalEncoderAction

To do:

Bug to fix: interpolation shortcut continues to flash when you're not in automation view
Bug to fix: fix pad grey out when entering menu

github-actions · 2024-03-09T04:10:37Z

Test Results

9 tests ±0 9 ✅ ±0 0s ⏱️ ±0s
2 suites ±0 0 💤 ±0
2 files ±0 0 ❌ ±0

Results for commit 81e484e. ± Comparison against base commit 08658cc.

♻️ This comment has been updated with latest results.

…Encoder Scrolling of Params Added "temporary" in-between automation editor layer to be able to edit params using the automation view editor UI without having to enter the full automation view UI to do it. When you're done editing and exit the menu, you are returned the previous UI you were in prior to entering the menu Added back select encoder scrolling of automation view parameters while in the full automation view UI Updated documentation Full automation view UI fine tuning: - When using the full automation view UI and entering the menu, the background UI will reset to the automation overview when first entering the menu and when you are not in a parameter menu - When using the full automation view UI, also enable editing the automation editor directly from the menu as users will come to expect this when using the in-between-UI. It also just makes sense. Refactored identical code out of Param:: and PatchCableStrength:: menu classes to a common Automation menu class Bug Fix Pad LED Greyout Cols and Rows mixup Fixed erroneous swap of pad LED cols and rows for assessing greyout

…Encoder Scrolling of Params (#1456) Added "temporary" in-between automation editor layer to be able to edit params using the automation view editor UI without having to enter the full automation view UI to do it. When you're done editing and exit the menu, you are returned the previous UI you were in prior to entering the menu Added back select encoder scrolling of automation view parameters while in the full automation view UI Updated documentation Full automation view UI fine tuning: - When using the full automation view UI and entering the menu, the background UI will reset to the automation overview when first entering the menu and when you are not in a parameter menu - When using the full automation view UI, also enable editing the automation editor directly from the menu as users will come to expect this when using the in-between-UI. It also just makes sense. Refactored identical code out of Param:: and PatchCableStrength:: menu classes to a common Automation menu class Bug Fix Pad LED Greyout Cols and Rows mixup Fixed erroneous swap of pad LED cols and rows for assessing greyout

…Encoder Scrolling of Params (SynthstromAudible#1456) Added "temporary" in-between automation editor layer to be able to edit params using the automation view editor UI without having to enter the full automation view UI to do it. When you're done editing and exit the menu, you are returned the previous UI you were in prior to entering the menu Added back select encoder scrolling of automation view parameters while in the full automation view UI Updated documentation Full automation view UI fine tuning: - When using the full automation view UI and entering the menu, the background UI will reset to the automation overview when first entering the menu and when you are not in a parameter menu - When using the full automation view UI, also enable editing the automation editor directly from the menu as users will come to expect this when using the in-between-UI. It also just makes sense. Refactored identical code out of Param:: and PatchCableStrength:: menu classes to a common Automation menu class Bug Fix Pad LED Greyout Cols and Rows mixup Fixed erroneous swap of pad LED cols and rows for assessing greyout

seangoodvibes added the cherry-pick Commit to cherry pick to release branch label Mar 9, 2024

seangoodvibes added this to the Release 1.1 milestone Mar 9, 2024

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch 4 times, most recently from 9d94dfb to 4ea2654 Compare March 9, 2024 06:39

seangoodvibes marked this pull request as draft March 9, 2024 06:40

seangoodvibes changed the title ~~Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params~~ [DRAFT] Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params Mar 9, 2024

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch from 97edccf to 29f1985 Compare March 9, 2024 19:56

seangoodvibes marked this pull request as ready for review March 9, 2024 19:58

seangoodvibes changed the title ~~[DRAFT] Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params~~ Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params Mar 9, 2024

seangoodvibes marked this pull request as draft March 9, 2024 20:26

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch from ff1bb34 to 0e14353 Compare March 9, 2024 20:37

seangoodvibes marked this pull request as ready for review March 9, 2024 20:37

seangoodvibes marked this pull request as draft March 10, 2024 00:01

seangoodvibes changed the title ~~Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params~~ [DRAFT] Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params Mar 10, 2024

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch 5 times, most recently from 4f1186c to fc1e4f8 Compare March 10, 2024 18:51

seangoodvibes changed the title ~~[DRAFT] Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params~~ Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params Mar 10, 2024

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch 2 times, most recently from b8d5017 to cd991ec Compare March 10, 2024 20:04

seangoodvibes marked this pull request as ready for review March 10, 2024 20:05

m-m-adams approved these changes Mar 17, 2024

View reviewed changes

m-m-adams added this pull request to the merge queue Mar 17, 2024

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Mar 17, 2024

seangoodvibes force-pushed the Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu branch from cd991ec to 81e484e Compare March 17, 2024 21:12

seangoodvibes added this pull request to the merge queue Mar 17, 2024

Merged via the queue into SynthstromAudible:community with commit 73af9db Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params#1456

Automation View ~ Interact With Editor From Menu + Re-instate Select Encoder Scrolling of Params#1456
seangoodvibes merged 1 commit into
SynthstromAudible:communityfrom
seangoodvibes:Allow-you-to-interact-with-automation/instrument-notes-grid-while-in-menu

seangoodvibes commented Mar 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 9, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

seangoodvibes commented Mar 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

seangoodvibes commented Mar 9, 2024 •

edited

Loading

github-actions Bot commented Mar 9, 2024 •

edited

Loading