Bipolar Params ~ Make Gold Knob LED indicators + Automation View Editor Bipolar#1480
Merged
m-m-adams merged 9 commits intoMar 17, 2024
Conversation
For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value
Contributor
seangoodvibes
changed the title
m-m-adams
requested changes
Mar 14, 2024
seangoodvibes
changed the title
Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
seangoodvibes
changed the title
m-m-adams
approved these changes
Mar 17, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…or Bipolar (#1480) * Make Gold Knob LED indicators + Automation View Editor Bipolar For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value * Update documentation * Address Feedback #1 * Address Feedback #2 * Address Feedback #3 * Address Feedback #4 * Address Feedback #4 - Update documentation * Address Feedback #5 * Bug fix blinking of middle knob pos Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…or Bipolar (SynthstromAudible#1480) * Make Gold Knob LED indicators + Automation View Editor Bipolar For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value * Update documentation * Address Feedback #1 * Address Feedback SynthstromAudible#2 * Address Feedback SynthstromAudible#3 * Address Feedback SynthstromAudible#4 * Address Feedback SynthstromAudible#4 - Update documentation * Address Feedback SynthstromAudible#5 * Bug fix blinking of middle knob pos Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For bipolar params:
Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value