Feature / Add shortcut to remove audio clip time stretching#1542
Merged
seangoodvibes merged 26 commits intoMar 22, 2024
Merged
Conversation
seangoodvibes
changed the title
Contributor
seangoodvibes
force-pushed
the
Feature-/-Remove-Audio-Clip-Timestretching
branch
3 times, most recently
from
March 21, 2024 05:06
389a087 to
1dde74c
Compare
Added a shortcut (SHIFT + <>) to remove audio clip time stretching by setting the audio clip length to the length of the audio sample
seangoodvibes
force-pushed
the
Feature-/-Remove-Audio-Clip-Timestretching
branch
from
March 21, 2024 05:26
2415bc1 to
7665b14
Compare
seangoodvibes
marked this pull request as draft
March 21, 2024 05:26
Calculate sample length in samples using green and red markers as start and end points (as opposed to using the original sample length)
…github.com/seangoodvibes/DelugeFirmware into Feature-/-Remove-Audio-Clip-Timestretching
m-m-adams
reviewed
Mar 21, 2024
m-m-adams
reviewed
Mar 21, 2024
Factored out loop length calculation logic to SampleHolder class
…github.com/seangoodvibes/DelugeFirmware into Feature-/-Remove-Audio-Clip-Timestretching
Removing some code that is no longer needed from previous merge
…github.com/seangoodvibes/DelugeFirmware into Feature-/-Remove-Audio-Clip-Timestretching
Fixed loop length calculation so that it always uses endPos
seangoodvibes
marked this pull request as ready for review
March 22, 2024 14:54
Updated audio clip sample loading to adjust loop length so sample is loaded without time stretching Updated combo to remove time stretching from Shift + <> to Vertical Encoder + <>
m-m-adams
approved these changes
Mar 22, 2024
m-m-adams
enabled auto-merge
March 22, 2024 19:45
seangoodvibes
disabled auto-merge
March 22, 2024 19:47
seangoodvibes
enabled auto-merge
March 22, 2024 19:49
seangoodvibes
added this pull request to the merge queue
Mar 22, 2024
Contributor
|
Could we cherry pick this into RC3 from 1.1 maybe? |
sichtbeton
pushed a commit
to sichtbeton/DelugeFirmware
that referenced
this pull request
Jun 22, 2024
…omAudible#1542) * Remove audio clip time stretching Added a shortcut (SHIFT + <>) to remove audio clip time stretching by setting the audio clip length to the length of the audio sample * Take green and red markers into account Calculate sample length in samples using green and red markers as start and end points (as opposed to using the original sample length) * remove reference to clip button as that now instantly changes to automation view * Bug fix Bug fix so that it works when you reverse the audio sample * reserve shift+press and turn x as a shortcut * Factor out loop length logic Factored out loop length calculation logic to SampleHolder class * Fix mistake * allow resizing audio clips without stretching * only restart if already playing * Add adjustLoopLength function * refactor to use setter methods * Remove some leftover code Removing some code that is no longer needed from previous merge * unify horizontal encoder and red endpoint adjustments * Fix loop length calculation Fixed loop length calculation so that it always uses endPos * factor out clip length change for reuse * use changecliplength method to avoid duplication * Load sample without stretching + change combo Updated audio clip sample loading to adjust loop length so sample is loaded without time stretching Updated combo to remove time stretching from Shift + <> to Vertical Encoder + <> * Fix horizontal encoder press * clarifying comment * update documentation --------- Co-authored-by: m-m-adams <mark.adams@queensu.ca>
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…omAudible#1542) * Remove audio clip time stretching Added a shortcut (SHIFT + <>) to remove audio clip time stretching by setting the audio clip length to the length of the audio sample * Take green and red markers into account Calculate sample length in samples using green and red markers as start and end points (as opposed to using the original sample length) * remove reference to clip button as that now instantly changes to automation view * Bug fix Bug fix so that it works when you reverse the audio sample * reserve shift+press and turn x as a shortcut * Factor out loop length logic Factored out loop length calculation logic to SampleHolder class * Fix mistake * allow resizing audio clips without stretching * only restart if already playing * Add adjustLoopLength function * refactor to use setter methods * Remove some leftover code Removing some code that is no longer needed from previous merge * unify horizontal encoder and red endpoint adjustments * Fix loop length calculation Fixed loop length calculation so that it always uses endPos * factor out clip length change for reuse * use changecliplength method to avoid duplication * Load sample without stretching + change combo Updated audio clip sample loading to adjust loop length so sample is loaded without time stretching Updated combo to remove time stretching from Shift + <> to Vertical Encoder + <> * Fix horizontal encoder press * clarifying comment * update documentation --------- Co-authored-by: m-m-adams <mark.adams@queensu.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed time stretching from samples that are loaded. Clip length is automatically set to the length of the sample.
Added new shortcut to remove timestretching from an audio clip and extend an audio clip without timestretching.
Press
▼︎▲︎+◀︎▶︎to set the Audio Clip length equal to the length of the audio sample. This will effectively remove timestretching from the audio sample.Press
SHIFT+◀︎▶︎+turn ◀︎▶︎to lengthen the audio clip without timestretching.Get it working for the full audio sample length (when you first load audio sample and haven't touched green and red waveform markers yet)
Get it working for the adjusted audio sample length (using green and red waveform markers)
Adjust code that sets new clip loop length to use the same functions as the current Shift + Turn <> combo)