Skip to content

sidebar: session macros in keyboard - #1545

Merged
m-m-adams merged 1 commit into
SynthstromAudible:communityfrom
bfredl:session_macros
Aug 9, 2024
Merged

sidebar: session macros in keyboard#1545
m-m-adams merged 1 commit into
SynthstromAudible:communityfrom
bfredl:session_macros

Conversation

@bfredl

@bfredl bfredl commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

One of my major workflow issues with the deluge has been, that while jamming on the keyboard on a part, jumping to song view and back to change some background part is just too many keypresses to switch to session view, press the right button which just wasn't visible until now and then jump back in to the correct keyboard part again, and now the "flow" of the jam is already lost.

Add a sidebar where the song parts can be controlled directly from the keyboard screen. This is done as 8 configurable "macros" which in this draft can be one of

  • switch given clip on/off
  • cycle all clips for a specific output
  • switch to a specific section (for all relevant output)

Suggestions for more behaviors welcome. Like I considered expanding the first option to layer any set of part in an arbitrary combination (not just sections), but wanted to start with something simple.

Very early draft, some missing pieces:

  • configure this sidebar directly from grid view
  • save macros with song
  • add validation for Clips/Outputs which might be deleted and now are dangling pointers
  • consider the right use of colors

@github-actions

github-actions Bot commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Test Results

99 tests  ±0   99 ✅ ±0   0s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
14 files   ±0    0 ❌ ±0 

Results for commit 1deba3a. ± Comparison against base commit fdc02a9.

♻️ This comment has been updated with latest results.

@bfredl
bfredl force-pushed the session_macros branch from f0a0962 to b9d0097 Compare May 7, 2024 11:04
@bfredl
bfredl force-pushed the session_macros branch 5 times, most recently from bf19703 to c6d286a Compare July 8, 2024 17:43
@bfredl
bfredl force-pushed the session_macros branch 2 times, most recently from 0978fba to 664b48e Compare July 17, 2024 10:45
@bfredl
bfredl force-pushed the session_macros branch 3 times, most recently from b676a02 to 3b9c9bc Compare July 28, 2024 14:42
@bfredl
bfredl marked this pull request as ready for review July 28, 2024 14:42
@bfredl bfredl changed the title [DRAFT] sidebar: session macros in keyboard sidebar: session macros in keyboard Jul 28, 2024
@bfredl

bfredl commented Jul 28, 2024

Copy link
Copy Markdown
Collaborator Author

Ready for review.

UI design: need a button combination for jumping to editing clip instead of launching. I picked AFFECT ENTIRE because it currently has no "latching" behavior in clips (it is always lit) and thus is safe as a modifier, and AFFECT+SONG is an ok combo for the left hand while picking the macro with the right hand. Other suggestions welcome.

@m-m-adams m-m-adams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits for now, maybe a few more once I've played with it a bit but the code looks pretty solid

Comment thread src/deluge/gui/ui/keyboard/column_controls/session.cpp Outdated
Comment thread src/deluge/gui/views/audio_clip_view.cpp
Comment thread src/deluge/gui/ui/keyboard/column_controls/session.cpp
@bfredl

bfredl commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator Author

thanks, updated

@seangoodvibes

Copy link
Copy Markdown
Collaborator

Hi,

I opened an issue as a follow-up to this PR as I don't want to hold off merging this.

Mostly just some UI consistency changes that I want to make.

#2414

@m-m-adams m-m-adams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight given Sean's promise I'm good to merge

@m-m-adams
m-m-adams added this pull request to the merge queue Aug 9, 2024
Merged via the queue into SynthstromAudible:community with commit aa4175b Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants