Skip to content

sound editor: "mod matrix" overview over all active patch cables - #157

Merged
jamiefaye merged 1 commit into
SynthstromAudible:communityfrom
bfredl:modmatrix
Aug 17, 2023
Merged

sound editor: "mod matrix" overview over all active patch cables#157
jamiefaye merged 1 commit into
SynthstromAudible:communityfrom
bfredl:modmatrix

Conversation

@bfredl

@bfredl bfredl commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

This provides a quick overview over all modulation which is active as part of a sound, similar to a "mod matrix" screen present in many synths.

TODO:

  • fine tune the UI for OLED. When a cable only have one source, we could fill in the current strength value in the "src2" slot
  • fine tune the UI for 7SEG. We want to use the blinkenlights to show source(s) and destination as the information doesn't fit on the screen.
  • shift-delete for quick deletion?

@m-m-adams

Copy link
Copy Markdown
Collaborator

What about highlighting destinations when a source shortcut is clicked, the inverse of the current click destination to highlight sources behaviour?

@litui litui added the enhancement New feature or request label Jul 12, 2023
@bfredl
bfredl force-pushed the modmatrix branch 4 times, most recently from bb58f72 to b72fc27 Compare August 7, 2023 19:19
@bfredl
bfredl force-pushed the modmatrix branch 4 times, most recently from 51fbf0a to a599ee3 Compare August 8, 2023 19:39
@bfredl
bfredl marked this pull request as ready for review August 8, 2023 19:40
@bfredl

bfredl commented Aug 8, 2023

Copy link
Copy Markdown
Collaborator Author

Now it is usable across devices. the screen scroll on 7seg is maybe not very readable (would need to invent yet a table of short parameter names), but you can navigate using shortcut blinks which is shown now as part of the menu.

@m-m-adams m-m-adams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

I'm not sure about the multi level modulations, the way they show up without a level looks like a bug compared to the other rows.

Maybe try like this?

src1[4] src2[4] intensity[4] dest[6],

with a space on both sides and between everything, and no scrolling. I think 6 characters is clear for all the modulatable params but I admittedly haven't looked that hard

@bfredl
bfredl marked this pull request as draft August 9, 2023 19:53
@bfredl

bfredl commented Aug 9, 2023

Copy link
Copy Markdown
Collaborator Author

src1[4] src2[4] intensity[4] dest[6],

I tried it but 6 chars for the dest is just too cramped, I am gonna use max 10 and for two sources shift everything and accept that those ones might need to scroll.

Too much weirdness around strings right now. (if not crashes, menu items randomly taking the wrong value). making draft until I figure out something which works.

@bfredl
bfredl force-pushed the modmatrix branch 2 times, most recently from b4c5cdf to 2d4b356 Compare August 12, 2023 09:55
@bfredl
bfredl marked this pull request as ready for review August 12, 2023 09:55
@bfredl

bfredl commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator Author

Did a bit more extensive testing, and for better and worse, the remaining crashes I see are the same as already on community firmware.

@bfredl
bfredl force-pushed the modmatrix branch 2 times, most recently from 5c91f39 to d07f09d Compare August 15, 2023 08:54
@bfredl

bfredl commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator Author

Seems stable now after rebasing on the change to use std::string_view for menu items.

@jamiefaye
jamiefaye added this pull request to the merge queue Aug 17, 2023
Merged via the queue into SynthstromAudible:community with commit caa8682 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants