Add a slice mode default setting#1589
Merged
sapphire-arches merged 18 commits intoSynthstromAudible:communityfrom Mar 26, 2024
Merged
Add a slice mode default setting#1589sapphire-arches merged 18 commits intoSynthstromAudible:communityfrom
sapphire-arches merged 18 commits intoSynthstromAudible:communityfrom
Conversation
When slicing audio into a kit, some users wanted to have a setting for a default playback mode for each sample. Would fix this: SynthstromAudible#849
m-m-adams
reviewed
Mar 25, 2024
sichtbeton
commented
Mar 25, 2024
m-m-adams
reviewed
Mar 25, 2024
sichtbeton
commented
Mar 25, 2024
Contributor
Contributor
Author
|
hopefully this is ok now |
seangoodvibes
approved these changes
Mar 25, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Add a slice mode default setting When slicing audio into a kit, some users wanted to have a setting for a default playback mode for each sample. Would fix this: #849 * some things changed but probably killed a lot * resolved all the comments. but it still doesnt compile * deleted the superfluous stuff * fixed all comments and deleted lines * changed the buffer thing to write to flash storage * a changeup in the list was not right, now correct * some code cleanup (lines and such) * further cleanup * documentation and changelog * clean uo again * reformat * 7 seg menu / changelog changes / buffer thing * reformat again * changelog * removed line
soymonitus
reviewed
Mar 26, 2024
|
|
||
| defaultStartupSongMode = StartupSongMode::BLANK; | ||
|
|
||
| defaultSliceMode = SampleRepeatMode::ONCE; |
Collaborator
There was a problem hiding this comment.
Isn't this changing the default Deluge behavior? Shouldn't this be CUT so if the users don't ever touch the Settings, it will behave like always? @seangoodvibes @sichtbeton
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* Add a slice mode default setting When slicing audio into a kit, some users wanted to have a setting for a default playback mode for each sample. Would fix this: SynthstromAudible#849 * some things changed but probably killed a lot * resolved all the comments. but it still doesnt compile * deleted the superfluous stuff * fixed all comments and deleted lines * changed the buffer thing to write to flash storage * a changeup in the list was not right, now correct * some code cleanup (lines and such) * further cleanup * documentation and changelog * clean uo again * reformat * 7 seg menu / changelog changes / buffer thing * reformat again * changelog * removed line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When slicing audio into a kit, some users wanted to have a setting for a default playback mode for each sample.
Would fix this: #849