Automation View ~ Bug fixes and added select scrolling of patch cables#1607
Merged
seangoodvibes merged 3 commits intoApr 1, 2024
Conversation
Contributor
seangoodvibes
force-pushed
the
Select-Scroll-Patch-Cables-in-Automation-View
branch
from
f8ff4ed to
1ec5e09
Compare
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Select-Scroll-Patch-Cables-in-Automation-View
branch
from
1ec5e09 to
87ad6a7
Compare
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Select-Scroll-Patch-Cables-in-Automation-View
branch
from
3ec214b to
211c096
Compare
…ources - Added select scrolling of patch cables that exist (they are dynamically added to the end of the non-patch cable param scrolling list for synths and kit rows) - Handled scenario where you selected a patch cable previously and it no longer exists when re-entering automation view. In this case it now sends you back to the automation overview. - Fixed select scrolling bug that would cause interpolation shortcut to blink profusely - Updated patch cable name displayed to show both sources if it's a patch cable with two sources
seangoodvibes
force-pushed
the
Select-Scroll-Patch-Cables-in-Automation-View
branch
from
211c096 to
f82e010
Compare
m-m-adams
reviewed
Apr 1, 2024
m-m-adams
approved these changes
Apr 1, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
#1607) * Select Scroll Patch Cables and Render Name for Patch Cable with Two Sources - Added select scrolling of patch cables that exist (they are dynamically added to the end of the non-patch cable param scrolling list for synths and kit rows) - Handled scenario where you selected a patch cable previously and it no longer exists when re-entering automation view. In this case it now sends you back to the automation overview. - Fixed select scrolling bug that would cause interpolation shortcut to blink profusely - Updated patch cable name displayed to show both sources if it's a patch cable with two sources * Update code and comments for clarity * Update documentation
sapphire-arches
pushed a commit
that referenced
this pull request
Apr 2, 2024
#1607) * Select Scroll Patch Cables and Render Name for Patch Cable with Two Sources - Added select scrolling of patch cables that exist (they are dynamically added to the end of the non-patch cable param scrolling list for synths and kit rows) - Handled scenario where you selected a patch cable previously and it no longer exists when re-entering automation view. In this case it now sends you back to the automation overview. - Fixed select scrolling bug that would cause interpolation shortcut to blink profusely - Updated patch cable name displayed to show both sources if it's a patch cable with two sources * Update code and comments for clarity * Update documentation
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
SynthstromAudible#1607) * Select Scroll Patch Cables and Render Name for Patch Cable with Two Sources - Added select scrolling of patch cables that exist (they are dynamically added to the end of the non-patch cable param scrolling list for synths and kit rows) - Handled scenario where you selected a patch cable previously and it no longer exists when re-entering automation view. In this case it now sends you back to the automation overview. - Fixed select scrolling bug that would cause interpolation shortcut to blink profusely - Updated patch cable name displayed to show both sources if it's a patch cable with two sources * Update code and comments for clarity * Update documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.