Change row color in session View #enhancement#163
Conversation
Change row color by pressing row & shift & vertical encoder. This is the same shortcut as in clip view.
kleinstar1
changed the title
|
Thanks for the contribution! If you don't mind, can you add some documentation for the user interface for this feature to the community features document? Otherwise I think this works well. CI failures are spurious and it works locally on my OLED deluge. |
|
Oh, I missed that - was wondering where to put that and where to find the new features list :) |
|
The trick is you need to add it to the list at the end of the file. See 479a27b for an example. |
sapphire-arches
left a comment
sapphire-arches
left a comment
There was a problem hiding this comment.
Some editorial comments as long as you're going to update this file again. Thanks again for the contribution!
|
|
||
| ### Instrument Keyboard View | ||
| - ([#46]) Note offset between rows is now configurable by holding shift and using the horizontal encoder. This allows e.g. an isomorphic keyboard layout by setting the row offset to 12. The setting is saved per clip in the song file. | ||
| ### Song View Row Colors |
There was a problem hiding this comment.
(minor nitpicks sorry, but I figure you're going to be in the area anyway...)
Should remove "Row Colors" here, since this section will have all the changes for "Song View"
| ### Instrument Keyboard View | ||
| - ([#46]) Note offset between rows is now configurable by holding shift and using the horizontal encoder. This allows e.g. an isomorphic keyboard layout by setting the row offset to 12. The setting is saved per clip in the song file. | ||
| ### Song View Row Colors | ||
| - ([#163]) Pressing a clip row + shift & scorll vertically changes the selected row color. This is the same shortcut like before when setting the color in the clip view. |
There was a problem hiding this comment.
Spelling error, "scorll" -> "scroll"
| ## New behaviors | ||
|
|
||
| ### Instrument Keyboard View | ||
| - ([#46]) Note offset between rows is now configurable by holding shift and using the horizontal encoder. This allows e.g. an isomorphic keyboard layout by setting the row offset to 12. The setting is saved per clip in the song file. |
There was a problem hiding this comment.
Probably shouldn't delete this section =)
|
Hope is better now - sorry for beeing beginnerisch :) |
|
Looking forward to adding this one. Let me know when its ready to go. |
Mostly LGTM, just 1 space missing that's upsetting the format checker. We sort of intentionally don't have a release yet, as we're not yet confident in the stability of the firmware. ok-reza is working on a community update document which I think he's planning to post to the forum and the facebook group in the next couple of days. If you want to brag about your features or ask for alpha testing don't let that stop you though. |
|
Would it be possible to add the ability to color a row with one constant value, making the row opaque and the session view much more readable? |
|
It's possible, but I think we should save that for a follow up change as it
would be much more involved.
…On Sat, Jul 8, 2023, 05:34 sichtbeton ***@***.***> wrote:
Would it be possible to add the ability to color a row with one constant
value, making the row opaque and the season view much more readable?
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALRZ7HWMXKU5JL2UMGWA3DXPFHW3ANCNFSM6AAAAAA2ANHWHM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This would throw away all current color calculations and thoughts from the synthstrom developers. The community somehow has to say what should be the best. This change would also be too much for my skills with this and code knowledge so far :) |
I hopefully fixed the spell checking and I hope that is ready to go :) |
I saw that recently :) |
|
Hey, |
|
A maintainer needs to approve the checks so they run. I think this is ready to merge otherwise, sorry for the wait! |
5 participants
Change row color by pressing row & shift & vertical encoder. This is the same shortcut as in clip view.
This helps a lot to setup clip colors - it shows the resulting line colors right in place in song/session view.