Skip to content

Add Note Row Play Direction to Synth / Midi / CV - #1739

Merged
m-m-adams merged 1 commit into
SynthstromAudible:communityfrom
seangoodvibes:Add-Play-Direction-to-Synth-Midi-CV-Note-Rows
Apr 19, 2024
Merged

Add Note Row Play Direction to Synth / Midi / CV#1739
m-m-adams merged 1 commit into
SynthstromAudible:communityfrom
seangoodvibes:Add-Play-Direction-to-Synth-Midi-CV-Note-Rows

Conversation

@seangoodvibes

@seangoodvibes seangoodvibes commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Added note row config of play direction for synth / midi / cv clips.

Hold audition pad while entering play direction menu

This also allows for quickly setting play direction for multiple note rows while in the note row play direction menu. Auditioning different note rows will refresh the play direction menu to show the play direction setting for each note row

I think we should merge this to 1.1 since we removed the previous kit workaround for setting note row play direction

@seangoodvibes seangoodvibes added the cherry-pick Commit to cherry pick to release branch label Apr 19, 2024
@github-actions

github-actions Bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Test Results

9 tests  ±0   9 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit c467551. ± Comparison against base commit 8f1a536.

♻️ This comment has been updated with latest results.

@seangoodvibes seangoodvibes added this to the Release 1.1 milestone Apr 19, 2024
Comment thread src/deluge/gui/menu_item/sequence/direction.h Outdated
@seangoodvibes
seangoodvibes marked this pull request as draft April 19, 2024 17:09
@seangoodvibes
seangoodvibes force-pushed the Add-Play-Direction-to-Synth-Midi-CV-Note-Rows branch from 7ba8f07 to 1fd10a1 Compare April 19, 2024 17:13
@seangoodvibes
seangoodvibes marked this pull request as ready for review April 19, 2024 17:16
@seangoodvibes
seangoodvibes force-pushed the Add-Play-Direction-to-Synth-Midi-CV-Note-Rows branch from 87e09aa to 7b2b88c Compare April 19, 2024 17:18
Added note row config of play direction for synth / midi / cv clips.

Hold audition pad while entering play direction menu

Added refresh of note row play direction menu when you change note row selection while in the menu
@seangoodvibes
seangoodvibes force-pushed the Add-Play-Direction-to-Synth-Midi-CV-Note-Rows branch from 7b2b88c to c467551 Compare April 19, 2024 17:19
@seangoodvibes
seangoodvibes requested a review from m-m-adams April 19, 2024 17:24
@m-m-adams
m-m-adams added this pull request to the merge queue Apr 19, 2024
Merged via the queue into SynthstromAudible:community with commit dcdbd6a Apr 19, 2024
github-actions Bot pushed a commit that referenced this pull request Apr 19, 2024
Added note row config of play direction for synth / midi / cv clips.

Hold audition pad while entering play direction menu

Added refresh of note row play direction menu when you change note row selection while in the menu
tastycode pushed a commit to tastycode/DelugeFirmware that referenced this pull request Jul 3, 2024
)

Added note row config of play direction for synth / midi / cv clips.

Hold audition pad while entering play direction menu

Added refresh of note row play direction menu when you change note row selection while in the menu
@seangoodvibes
seangoodvibes deleted the Add-Play-Direction-to-Synth-Midi-CV-Note-Rows branch December 11, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Commit to cherry pick to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants