Skip to content

Make Hold Time Configurable#1846

Merged
m-m-adams merged 2 commits into
SynthstromAudible:communityfrom
seangoodvibes:Make-Hold-Time-Configurable
May 6, 2024
Merged

Make Hold Time Configurable#1846
m-m-adams merged 2 commits into
SynthstromAudible:communityfrom
seangoodvibes:Make-Hold-Time-Configurable

Conversation

@seangoodvibes
Copy link
Copy Markdown
Collaborator

@seangoodvibes seangoodvibes commented May 6, 2024

Added new default hold press time menu to configure default time to trigger hold presses in various views, namely:

  • stick shift
  • performance view
  • keyboard sidebar

Fix: #1725

@seangoodvibes seangoodvibes added the cherry-pick Commit to cherry pick to release branch label May 6, 2024
@seangoodvibes seangoodvibes added this to the Release 1.1 milestone May 6, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2024

Test Results

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 3 files   ±0    0 ❌ ±0 

Results for commit b1509d3. ± Comparison against base commit b169be5.

♻️ This comment has been updated with latest results.

@seangoodvibes seangoodvibes force-pushed the Make-Hold-Time-Configurable branch from f09217a to 450516a Compare May 6, 2024 01:19
Added new default hold press time menu to configure default time to trigger hold presses in various views, namely:

- stick shift
- performance view
- keyboard sidebar
@seangoodvibes seangoodvibes force-pushed the Make-Hold-Time-Configurable branch from 8a93135 to 2c4a9ee Compare May 6, 2024 01:20
@m-m-adams m-m-adams added this pull request to the merge queue May 6, 2024
Merged via the queue into SynthstromAudible:community with commit ece66d1 May 6, 2024
tastycode pushed a commit to tastycode/DelugeFirmware that referenced this pull request Jul 3, 2024
Added new default hold press time menu to configure default time to trigger hold presses in various views, namely:

- stick shift
- performance view
- keyboard sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Commit to cherry pick to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sticky shift window is (subjectively) too short

2 participants