Skip to content

Manual slicing - #198

Merged
jamiefaye merged 5 commits into
SynthstromAudible:communityfrom
alter-alter:manual-slicing
Jul 17, 2023
Merged

Manual slicing#198
jamiefaye merged 5 commits into
SynthstromAudible:communityfrom
alter-alter:manual-slicing

Conversation

@alter-alter

@alter-alter alter-alter commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

In the Slicer view, press the ◀︎▶︎ knob. When you press the green pad in the bottom left, it starts playing the first slice, and pressing an empty pad creates a new slice. Turning the Select knob to the left or pressing the Pad + DELETE button allows you to delete a slice.

Turning the ◀︎▶︎ knob allows you to adjust the start point of the slice. Additionally, turning the ▼︎▲︎ knob transposes the slice.

Pressing the Select knob finalizes the slicing process.

https://youtu.be/w_1FBTHhPNs

Update slicer.cpp
@weavermedia

weavermedia commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Is it possible for the displayed transpose value to follow the last played pad? Currently if you play a pad and transpose it, say -5, that -5 will continue to flash on the display after you play a different pad, which is confusing if the current pad transpose value is different.

Could the display be updated on every pad press to show the transpose value for the current pad? If no transpose is set for the current pad it could just show the pad number, like normal.

@alter-alter

alter-alter commented Jul 17, 2023

Copy link
Copy Markdown
Contributor Author

To avoid confusion, the slice number pops up when the pad is pressed. Additionally, pressing the ▼▲ Encoder displays the transpose value of the current pad.

@weavermedia

weavermedia commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

To avoid confusion, the slice number pops up when the pad is pressed.

Not on 7-seg. On 7-seg the transpose stays on the display even after you press another pad. Regardless of whether that new pad has a different transpose settings or no transpose setting at all.

In the video watch the display continues to show the value even after a different pad is pressed.

EDIT: just saw you adding changes as I'm commenting 😀 I'll check them out asap 👍

Deluge-ManualSlice-TransposeDisplay.mp4

@weavermedia

weavermedia commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

@alter-alter Could you do a build in your own fork for these latest changes? That's where I'm previewing this feature from. I don't know how to checkout a PR on my local machine in order to build it.

@weavermedia

weavermedia commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

@alter-alter Never mind, I figured it out 😀

Testing the new changes and it's better that the old transpose values don't show but the new way has problems too.

Showing the slice number on every pad press means that if you're tapping a pad while transposing (to hear the effect) you don't really get to see the transpose value properly on the screen. This is because every tap of the pad replaces the transpose value with the slice number.

Is it possible maybe to hold the transpose value on the display for a second before changing back to displaying the slice number? Basically ignore any display updates called by pad presses for the duration of 1 second after every change to the transpose amount. Just a thought.

Maybe ignore all consecutive presses of the same pad? That seems like it would solve both problems. It would allow the transpose value to show on the display if you're tapping the same pad but then change to show the slice number when you hit a new pad.

@alter-alter

alter-alter commented Jul 17, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the feedback.

  • Transpose popup is now turned off when another pad is pressed.
  • The slice number popup (fd00ebd) is no longer displayed.

@sichtbeton

Copy link
Copy Markdown
Contributor

Couldn't check it out yet, but does it convert the chops to kit rows? Because then you can alter the sound of each chop further. And adding to that: is it possible to clone a chop?

@alter-alter

Copy link
Copy Markdown
Contributor Author

@sichtbeton Yes, it is possible to convert the chops to kit rows. Press the select encoder in the same way as in slicer mode.
However, cloning a chop is not currently supported.

@sichtbeton

Copy link
Copy Markdown
Contributor

@sichtbeton Yes, it is possible to convert the chops to kit rows. Press the select encoder in the same way as in slicer mode.
However, cloning a chop is not currently supported.

Omg this is great! Thank you. Can’t wait to try it out.

@jamiefaye
jamiefaye added this pull request to the merge queue Jul 17, 2023
Merged via the queue into SynthstromAudible:community with commit 678df4f Jul 17, 2023
@weavermedia

Copy link
Copy Markdown
Contributor

@alter-alter Excellent! Feels really smooth now 👏

@sichtbeton

sichtbeton commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

one issue: when audio preview is enabled in the menu (preview=on) the sample will play completely through. chops can be made but the first triggered preview of the sample is playing underneath making it impossible to work.

@alter-alter

Copy link
Copy Markdown
Contributor Author

@sichtbeton Thank you for the feedback. Currently, when entering Slicer mode, the preview gets cut off by pressing Shift + Select, but it seems that the preview is not cut off when entering from the menu by long-pressing the Select encorder. I will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants