Feature: Add Note Velocity Editor to Automation View

[seangoodvibes]

Feature: Automation View Note Velocity Editor

New Note Velocity Editing View that has been added as part of the existing Automation View implementation so that you can edit the velocities and other parameters of notes in a single note row.

Description:

• imagine if the whole grid was just one note row, or one kit row
• each column of colours represents a note
• the vertical colours represents that notes velocity which you can edit by interacting with the grid (like you would with a parameter in automation view)

Outstanding Items:

Future PR Work

• Code Review + Refactoring
• Fix note editor state so that it is clip specific and not view specific (e.g. entering note editor in one clip should not cause another clip with automation view open to enter note editor).
• Fix selected note row so that it is clip specific and not view specific
• Bugfix - Might still be an issue with 7seg display but can't reproduce.
• Fix any bugs / tweaks needed for velocity ramps
• Add ability to shift velocity ramp up down
• Add velocity ramp selection to pad selection mode
• Add ability to switch from left to right pad while velocity ramp is selected
• Activate gold knobs for adjusting velocity ramp when it is selected?
• Refactor audition pad action in automation view to call code in instrument clip view as there is duplication
• LastAuditionedYDisplay can become out of sync with selected drum in a kit

Completed

• Fix note row selection blinking when re-entering automation view after exiting
• Fix grey out of velocity editor when entering menu
• Fix Shift + <> to shorten / extend the note row's length and not the clip's length while in note editor
• Change note deletion to happen when you press pad that corresponds to squares average velocity
• Change bottom pad press to set velocity to 1 instead of deleting note
• Fix <> + back to clear only the selected note row's notes and not the entire clip
• Enter velocity view with audition pad + velocity shortcut from instrument clip view
• Fix note probability editing - you can now press and hold on the top velocity pad in a column to edit the note's probability
• Fix note repeat editing - you can now press and hold on the top velocity pad in a column to edit the note's repeats
• Enable cross screen velocity note editing
• Fix 7SEG display rendering
• Bugfix - Switching from pad selection mode in note editor to another param keeps you in pad selection mode, but it seems like left pad selection is stuck. Fix it by exiting pad selection mode b4 switching to other params with shortcut.
• Add quantize / humanize combo (audition pad + press and turn tempo)
• Add velocity ramps - Change velocity of all notes between two presses
• Velocity ramp - Fixed bug where OLED display would not show L and R position of Velocity ramp even while still multi pad press is active
• Fix notes recorded in with audition pads not rendering until you turn off recording
• Fix 7Seg display rendering for velocity ramps
• Update row probability so that you can edit row probability by just turning select while you are outside pad selection mode and aren't currently holding a note press
• Re-added note row transpose shortcut (Press + turn vertical encoder)
• Add shortcuts for rotating note row press vertical + press and turn <> and press audition + Press and turn <>
• Add horizontal scrolling and zooming into pad selection mode
• Add waveform shortcut blinking to indicate you're in pad selection mode
• Fix pad selection mode can't be enabled while in menu view
• Fix euclidean - it removes notes entered by previous euclidean actions (e.g. enter euclidean notes on one note row, then switch to another note row and add notes with euclidean and then remove them - it will removes notes from current note row and previous note row - I think it's because it's doing an "undo" action
• Bugfix - Sometimes note row selected and velocity shortcut doesn't blink (noticed it when jumping from automation editor to velocity editor) - Also noticed it exiting out of velocity editor into instrument clip view and back into velocity view

Quick Overview:

• Enter the Velocity Editor View by:
  • While in the Automation Instrument Clip View, use Shift + Velocity or press Velocity pad on Automation Overview to enter the Velocity Note Editor
    OR
  • While in the Instrument Clip View, hold Audition pad + Press Velocity shortcut pad
• Select note row:
  • Press audition pad or Vertical scroll to select different note rows
  • The audition pad will blink to indicate the currently selected note row
  • The display will indicate the note code / drum name of the row you have selected
• Add Note / Adjust Velocity Using Grid:
  • Press grid to set/adjust velocities of existing notes and add note (if no note exists)
• Set a Velocity Ramp:
  • Press and hold two grid note pads to set a velocity ramp between the two notes.
  • Note: for this to work, you must first press a pad that has a note in it and then press a second pad that has a note in it. if the second pad has no note already in it, it will set a tail instead for the first note pad pressed (or if it's a drum sound, like a kick, it will just add another note in the position of the second pad press).
• Remove Note:
  • Short press top velocity pad in a note column to remove note
• Select Note and Adjust Note Parameters:
  • Long press top velocity pad in a note column to see note's velocity and perform note related adjustment actions (e.g. adjust velocity, probability). Note press related actions include:
    • Adjust Velocity: Turn horizontal encoder <>
    • Adjust Probability: Turn Select Encoder
    • Adjust Note Repeat: Press and Turn Vertical Encoder
    • Adjust Automation: Turn gold knobs
• Adjust Note Row Transpose:
  • Press and turn vertical encoder
  • Note: does not work if you are holding a note (transpose gets replaced with editing note repeats)
• Adjust Note Row Probability:
  • Hold Audition Pad + Turn Select Encoder to change the selected Note Row's probability
    • Note: does not work if you are currently holding a note
• Add/Remove Notes with Euclidean:
  • Hold Audition Pad + Press and turn vertical encoder
  • Note: The Euclidean action is replaced by note repeat editing if you have selected a note (either by holding a note outside pad selection mode or if you are in pad selection mode)
• Change clip length:
  • Hold Shift + turn horizontal encoder <>
• Change selected note row length by:
  • Holding Audition pad + Turning horizontal encoder <>
  • Note: does not work if you have selected a note
• Clear notes in selected note row by:
  • Holding horizontal encoder <> + pressing Back
  • Note: does not work if you have selected a note
• Rotate Note Row by:
  • Holding vertical encoder + turning horizontal encoder <>
  • Holding audition pad + pressing and turning horizontal encoder <>
  • Note: does not work if you have selected a note
• Quantize / Humanize notes by:
  • Enabling Quantize community feature
  • Hold audition pad + press and turn tempo encoder to set quantize / humanize %
• Cross Screen Editing:
  • Press cross screen while in the Velocity Note Editor to edit notes across multiple screens.
  • Note: you can only toggle cross screen editing if the clip has multiple screens OR the current note row selected has multiple screens.

** Future PR Functionality: **

The following functionality was removed from this PR as it still needs work.

• Pad Selection Mode:
  • Press Shift + Waveform to enter Pad Selection Mode
  • Pad Selection Mode allows you to select note and perform all the same actions as if you were holding that note's pad. This includes:
    • Turn <> to adjust the selected note's velocity (in pad selection mode you can also hold shift to adjust the note's velocity more quickly)
    • Press Shift + Turn <> to adjust selected notes velocity faster
    • Press + Turn vertical encoder to adjust the selected note's repeats
    • Turn select encoder to adjust the selected note's probability
    • Note: to use the following actions in Pad Selection Mode, you need to first de-select a note by pressing that note again:
      • Horizontal scrolling (Turn <>)
      • Zooming (Press + Turn <>)

Some Demo Videos:

Euclidean Fun:

IMG_9140.mov

Playing with Probability:

IMG_9233.mov

Euclidean and Probability Together:

IMG_9364.mov

Enter Velocity Ramps for Existing Notes:

IMG_9312.mov

[github-actions]

Test Results

46 tests  ±0   46 ✅ ±0   0s ⏱️ ±0s
 8 suites ±0    0 💤 ±0 
 8 files   ±0    0 ❌ ±0 

Results for commit 046cbf2. ± Comparison against base commit 35131d2.

♻️ This comment has been updated with latest results.

[m-m-adams]

Featurewise my last nit is that holding a note and turning <> encoder should fine tune velocity (same as it does outside velocity automation view)

[m-m-adams]

Automation view should be split into two, just make a note automation view that inherits from automation view and overrides the functions that are checking inNoteEditor() right now. It'll reduce the spaghetti factor by a ton and also run more efficiently

Coming along well though!