bugfix: use normal pan value scaling for reverb::Pan - #2080
Merged
sapphire-arches merged 1 commit intoJun 2, 2024
Merged
Conversation
- Fixes SynthstromAudible#2063. All panning uses the same doPanning() function, so same value scaling is correct for reverb as well. - No need to adjust save/load logic: any old saved values will be used as-is and sound the same, they will just display differently. - This gives access to fully wet and dry sounds if you pan master fully one way and reverb fully the other way.
nikodemus
force-pushed
the
reverb-pan-value-scaling
branch
from
June 2, 2024 18:07
a05025f to
33e024e
Compare
Contributor
sapphire-arches
added this pull request to the merge queue
Jun 2, 2024
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…le#2080) - Fixes SynthstromAudible#2063. All panning uses the same doPanning() function, so same value scaling is correct for reverb as well. - No need to adjust save/load logic: any old saved values will be used as-is and sound the same, they will just display differently. - This gives access to fully wet and dry sounds if you pan master fully one way and reverb fully the other way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reverb pan values do not roundrip #2063. All panning uses the same doPanning() function, so same value scaling is correct for reverb as well.
No need to adjust save/load logic: any old saved values will be used as-is and sound the same, they will just display differently.
This gives access to fully wet and dry sounds if you pan master fully one way and reverb fully the other way.