exit UIs on long press back#2166
Merged
Merged
Conversation
Contributor
Collaborator
|
This works really well. Love this. Can we add an entry to change log and community features (general improvements) for this? |
seangoodvibes
approved these changes
Jun 24, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
* exit UIs on long press back * fix format * add to docs * return whether UI exited
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* exit UIs on long press back * fix format * add to docs * return whether UI exited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements long press back to exit menus as a fast and consistent everywhere alternative to pressing the sidebar as mentioned in #2027
Make exitUI a virtual function in UI rather than separate per class functions
When back is pressed start a timer to exit the current UI
UIs can exit on long press back by implementing exitUI. Currently the following UIs exit (basically everything that has an instant exit ability already)
Also reduces the long hold from 500 to 400 - this feels good for the existing long press functions and 500 felt too long for holding back to exit. Open to putting that back though