Exit ui if top left sidebar pad pressed#2174
Merged
Merged
Conversation
Contributor
Add community features menu toggle to enable exiting menus while in keyboard view using the top left sidebar pad
Fix typo
seangoodvibes
approved these changes
Jun 25, 2024
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jun 25, 2024
* exit ui if top left sidebar pad pressed * Add community features toggle Add community features menu toggle to enable exiting menus while in keyboard view using the top left sidebar pad * Update documentation Fix typo * only exit while button is held to stop latching menus shut --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com>
seangoodvibes
added a commit
that referenced
this pull request
Jun 25, 2024
…ar-pad-pressed Exit ui if top left sidebar pad pressed (#2174)
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* exit ui if top left sidebar pad pressed * Add community features toggle Add community features menu toggle to enable exiting menus while in keyboard view using the top left sidebar pad * Update documentation Fix typo * only exit while button is held to stop latching menus shut --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be wrapped in a community feature since the UI is not great right now (no dimming, no indication of what happened) but this should be serviceable for 1.1