Feature: Automatic Stem Exporting#2260
Conversation
dec2730 to
93d3169
Compare
|
First of all: this is amazing. As far as I remember, this feature is the most requested of alle times in the community of the Deluge, by far. So thank you so much for doing this! Excellent: Bugs i found so far:
a couple of thoughts / improvements:
more additions, which are probably a different feature PR altogether:
but, besides the little bug not recording from the very first second on, even in this state it already is a MAJOR improvement for exporting tracks. my prayers have been anwered. thx! |
|
Feedback from @trappar for future PR I feel like a robust implementation for this should eventually support things like:
|
|
And if this all wasnt too much of a wishlist:
|
|
Another request on Facebook:
|
|
Re: normalization If you’re able to disable that I’d definitely make that an option rather than always disabling it. Personally if I was going to export stems for a regular DAW I’d prefer the samples be normalized so that I could do my mixing in the daw rather than baking mixing into samples. I guess if the thing being exported is clips, I'd expect normalization. If it's exporting the arrangement (stems) I would not expect normalization. Perhaps these are really two different features? |
|
Yep think so too, it should be optional. With for exporting stems and have the mix be kept intact or normalized for maximum levels. |
I think a Normalization menu setting that has 4 options would work:
|
5ccea28 to
0c6256a
Compare
Added automated process for exporting clip stems while in song view and instrument stems while in arranger view Shortcuts are: - Hold Save + Press Record while Playback and Record are disabled to launch Stem Export process - Press Back to cancel Stem Export process
222865d to
db2e880
Compare
Don't start recording for MIDI and CV outputs
m-m-adams
left a comment
There was a problem hiding this comment.
With a change to yield instead of using the timer manager I think this looks good!
meaningful wav file names are now set for stem exports in the format of: OutputType_StemExportType_OutputName_IndexNumber.WAV example: SYNTH_CLIP_BASS SYNTH_00000.WAV example: SYNTH_TRACK_BASS SYNTH_00000.WAV
Updated stem exporting to use yield which removed need for timer and enabled me to clean up a lot of the extra variables that were added to manage the timer loop. Removed code that was arming clips before recording as it was not necessary.
Added context menu for cancelling stem export so that you can confirm if you really want to cancel or not
If you're in the cancel context menu when the stem export job is completely finished, exit out of it
2ae56a9 to
41fd7d0
Compare
Accidentally moved the code for my previous fix to the wrong spot in one my refactorings oops
Excluded muted tracks in arranger view from stem export
f543a41 to
8600b53
Compare
Stem Exports are now exported before Master FX (Output source = MIX)
8600b53 to
ef235db
Compare
m-m-adams
left a comment
There was a problem hiding this comment.
One small nit, looks good!
Moved code for getting full stem file path out of audio file manager and into the stemExport class
Fixed bug where resampling wouldn't end when recording source was set to mix
|
Monumental PR. Thank you @seangoodvibes ! |
|
Hi, first of @seangoodvibes all thanks for implementing stem-export! |
Hey, that shouldn't be happening. As you expected, it should be exporting each instrument up to the length of the arrangement. Other people have reported a similar bug. Are you able to share a collect all saved version of your song so I can try and see what's going on? Can you confirm if this also happens with a new song? Thanks |
|
Sorry I'm not sure what you mean with "collect all saved version". If you explain a bit more what exactly you need, I can try. |
Hey, so your description gives me a clue. You said the recording took very long. Did it continue recording after the playhead reached the end of the instrument track? If so, it's possible you're experiencing a problem similar to what someone else reported. Basically, by default, the stem export will record the full length of the arrangement, but it will also keep recording afterwards if the sound has not yet dropped to zero. This allows it to record tails in the stems. There seems to be a scenario, which may or may not be a bug, where the tails keep playing and the sound does not fully drop to zero. if you turn on the VU meter before starting the stem export, you can see whether or not the VU meter drops to zero at the end of the recording. You can also try the release build from here: https://github.com/SynthstromAudible/DelugeFirmware/actions/runs/10435480991?pr=2456 I've added an option in the SONG > STEM EXPORT > CONFIGURE menu where you can turn off EXPORT TO SILENCE By doing that, it will not record tails and it will finish recording the stem at the end of the arrangement length. Could you try and see if turning off "Export to Silence" solves your issue? Thanks |
|
I tried with a new song now, and with a 4 bar arrangement I have now a 16 seconds long wave with a filesize of ~2mb. Previously I had filesize of 88MB but only 5 seconds even though it should have been 5:20 min, which is super odd. |
|
I now tried with the VU meter and cross-screen engaged in order to see the behaviour at the end, but it pretty much directly at the end of the song jumps to the next instrument and at that moment VU shows silence. |
|
Just to let you know, tonight I tried again with deluge-v1_2_0-beta+2024_09_02-6d9319b and afterwards with deluge-v1_2_0-nightly+2024_09_02-8d0d66d and my problem is still the same, all 80+ mb wavs play only 5 seconds of audio. |
Did you post in our discord earlier today about this? if not, I'll suggest the same thing I suggested to that person:
If changing to "mutable" fixes your problem, can you try using "mutable" with "record to silence" turned on as well to confirm you can export successfully with record to silence as well. Thanks |
|
No I didn't post on Discord but on the Facebook-group about it. If you reread our above back and forth posts about the issue, I already tried your suggestions without that I managed to get a different outcome. And I'm using Mutable Reverb, so that shouldn't cause this issue. I tried engaging Stem-render per menu, turned off to silence, looked at the VU meter and it goes to zero at the end of the track, tried with and without FX, I always end up with ~80mb big wave-files with only 5 seconds playing. |
It sounds like you have the same issue as reported here #2573 Can you please upload a collect all version of your song to that issue (you can drag and drop a file into the comments box). Can you also please confirm if this issue happens with all your songs or just this one. Thank you For future reference, please open an issue for problems like this instead of discussing it on the feature PR itself. That's what issues are for and it helps us keep track of things. I would not have known you commented here if GitHub didn't send me an email about it. |
|
Yes, #2573 is exactly the bug I discussed with you 2 weeks ago. |
lets continue on #2573 please you can collect all and save as follows:
Then just zip the folder and upload it in the issue #2573 Thanks |
Automated Stem Exporting
IMG_9747.mov
Description
Added
STEM EXPORT, an automated process for exportingCLIP STEMSwhile inSONG VIEWandINSTRUMENT STEMSwhile inARRANGER VIEW. PressSAVE + RECORDto start exporting stems.Now with one quick action you can start a stem export job, walk away from your Deluge and come back with a bunch of stems for all your clips and arranger instruments.
Stems Folder
Stems get exported to a new
SAMPLES/STEMS/folder.Within the
STEMSfolder, a folder with theSONG NAMEis created for each stem export job which contains all the WAV file recordings.If the same SONG is exported more than once, a 5 digit number incremental number is appended to that song's folder name.
Stem File Names
Stem's are given a meaningful name in the following format:
ClipType_ExportType_PresetName_FileNumber.WAVShortcuts to Start/Stop Stem Exporting
Starting Stem Export
SAVE+ PressRECORDwhile Playback and Record are disabled to launch Stem Export processSELECT,BACKor anyPADon the grid to exit the dialog.MUTEDwill be excluded from the stem export.Cancelling Stem Export
BACKto cancel Stem Export processSELECTencoder to confirm that you want to cancel. PressBACKor anyPADon the grid to exit out of the dialog and continue with stem export process.BACK, the stem export still continues in the background until you confirm you want to stop.Addresses: #2254
Videos
IMG_9757.mov
IMG_9771.mov
IMG_9773.mov