Add New Clip Type Menu and Remove Yellow Grid Mode

[seangoodvibes]

Description

Added new clip type context menu that opens on creation of a new clip in song view which enables you to select the type of clip before the clip is created, removing the need to create a synth clip and then change its type afterwards.

This frees up the press clip and press select encoder shortcut to be used to selecting the clips launch style.

Removed grid view yellow mode (from #1494) because you can now select clip launch style in all grid view modes.

Usage:

Add new clip by pressing an empty row or adding a clip to an empty column in grid view.

A menu will open enabling you to select the type of clip that you wish to create. The options are:

1. Audio clip
2. Synth clip
3. Kit clip
4. MIDI clip
5. CV clip

Select the type by scrolling to it in the menu and pressing the select encoder to create a clip with that type.

Alternatively, while the menu is open, you can also select Synth/Kit/MIDI/CV by pressing the corresponding deluge buttons.

If you exit the menu (by pressing back or pressing the grid) then no clip will be created.

[github-actions]

Test Results

99 tests  ±0   99 ✅ ±0   0s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
14 files   ±0    0 ❌ ±0 

Results for commit 36d8efb. ± Comparison against base commit 41c2828.

♻️ This comment has been updated with latest results.

[schlesstones]

Hi, this is just one person's opinion, but I've used this UI change for a few days and I find it very cumbersome for my workflow, mostly because we have removed the ability to convert a non-audio clip to an audio clip:

• I often start a project with an empty audio clip for looping (using auto-tempo), which means the audio clip has to be the only clip in the song. So, while I used to just press and hold the clip and then press select, I now have to add an audio clip and then delete the synth clip because there is no longer a way to convert it to an audio clip.
• Because there is no dedicated "Audio" button or gesture, I must use the scroll menu to create an audio clip which pulls me out of the "flow" of audio creation. It sounds silly but avoiding menus while making music is one of the things I love the most about Deluge.

I do understand wanting to make the UI consistent for "press clip and press select encoder", so I have a suggestion:

• Could SHIFT->CV be the shortcut to turn a non-audio clip to an audio clip?
• For those of us who don't use CV at all, could there be a community menu item to make the CV button a dedicated "audio button"?

Anyway thanks for considering! Let me know if there is an alternate place I should be placing beta test feedback for community UI features. Thanks!

[m-m-adams]

Hey we're looking at adding back the audio conversion option (will be a popup menu)

That said I'll offer two suggestions

1. You can create a default song DEFAULT.xml and enable the startup song feature. That will let you create a new default with an audio clip already created in new songs
2. The popup menu for creating a new clip can be totally ignored, the exact same hold empty row and press select action will still make an audio clip. Similarly holding the row and pressing synth/kit/midi/cv buttons immediately creates the appropriate clip

There's some more discussion on github but someone might move forward with repurposing the cv button for audio clips and relegating cv clips to a menu

[schlesstones]

Hi thanks for responding! This all makes sense.

Put me down as a strong vote for repurposing the CV button for audio tracks! :-)

[todd-gochenour]

I just tested this feature. I was hoping that the clip name would replace the current preset name shown in large type on the UI screen. Especially when I've created a new synth 'Synt1' and give it a name, I see:

          Synth
          SYNT1
     1: My Named Clip

centered in the UI leaving no space for anything else. I would like to see the key and scale information here on the third line, as that information is more important when interacting with the clip than the name 'Synt1' or 'Rich Saw Bass'.

I would like to see:

   1/16          Synth       # 120
           1: My Named Clip
   C-2 Harmonic Minor

where the upper left corner reveals the current zoom level, the upper right corner reports BPM, the lower left corner reveals the key and scale and the lower right corner is free for something else.