Skip to content

Render Clip and Section Launch Playhead in Song Grid and Performance Views - #2315

Merged
seangoodvibes merged 1 commit into
SynthstromAudible:communityfrom
seangoodvibes:Render-Clip-Launch-Playhead
Jul 26, 2024
Merged

Render Clip and Section Launch Playhead in Song Grid and Performance Views#2315
seangoodvibes merged 1 commit into
SynthstromAudible:communityfrom
seangoodvibes:Render-Clip-Launch-Playhead

Conversation

@seangoodvibes

@seangoodvibes seangoodvibes commented Jul 20, 2024

Copy link
Copy Markdown
Collaborator

A white playhead is now rendered in Song Grid and Performance Views that lets you know when a clip or section launch event is scheduled to occur. The playhead only renders the last 16 notes before a launch event.

  • Note: this playhead can be turned off in the Community Features submenu titled: Enable Launch Event Playhead (PLAY)

The display also now shows the number of Bars (or Notes for the last bar) remaining until launch in all Song views (Grid, Row, Performance).

@seangoodvibes seangoodvibes added this to the Release 1.2 milestone Jul 20, 2024
@github-actions

github-actions Bot commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Test Results

75 tests  ±0   75 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
13 files   ±0    0 ❌ ±0 

Results for commit 8807fa5. ± Comparison against base commit e7a8747.

♻️ This comment has been updated with latest results.

@seangoodvibes seangoodvibes changed the title Render Clip and Section Launch Playhead in Song Grid and Performance Views [DRAFT] Render Clip and Section Launch Playhead in Song Grid and Performance Views Jul 20, 2024
@seangoodvibes
seangoodvibes marked this pull request as draft July 20, 2024 21:18
@seangoodvibes
seangoodvibes force-pushed the Render-Clip-Launch-Playhead branch 3 times, most recently from 4dbf48a to 7602cfe Compare July 24, 2024 04:04
@seangoodvibes seangoodvibes changed the title [DRAFT] Render Clip and Section Launch Playhead in Song Grid and Performance Views Render Clip and Section Launch Playhead in Song Grid and Performance Views Jul 24, 2024
@seangoodvibes
seangoodvibes marked this pull request as ready for review July 24, 2024 04:05
@soymonitus

Copy link
Copy Markdown
Collaborator

Was the playhead finally moved to the last row? If no, please, consider this idea even though the playhead shows on top for the keyboard view, as the top row in grid mode is usually full of clips.

Besides, why rendering red on quarters? It makes the sequence more crazy. The playhead already is easy to follow as it renders 16th notes,.. no need for quarters. It would be needed if you were only to render the quarter notes and not the 16th notes

@seangoodvibes
seangoodvibes force-pushed the Render-Clip-Launch-Playhead branch from 1b48284 to 7c3caf9 Compare July 26, 2024 13:10
Renders a white clip and section launch playhead in Song Grid View and Performance View that let's you know when a clip or section launch event is scheduled to occur

Added community features menu so that launch event playhead can be turned off

Displays pop-up with number of bars and notes remaining before launch
@seangoodvibes
seangoodvibes force-pushed the Render-Clip-Launch-Playhead branch from 7c3caf9 to 8807fa5 Compare July 26, 2024 13:12
@seangoodvibes

Copy link
Copy Markdown
Collaborator Author

Was the playhead finally moved to the last row? If no, please, consider this idea even though the playhead shows on top for the keyboard view, as the top row in grid mode is usually full of clips.

Besides, why rendering red on quarters? It makes the sequence more crazy. The playhead already is easy to follow as it renders 16th notes,.. no need for quarters. It would be needed if you were only to render the quarter notes and not the 16th notes

Updated it so it's just a white playhead

As for the "playhead in top row" let's play with it first. maybe we can make it customizable as part of the community feature toggle.

@seangoodvibes
seangoodvibes enabled auto-merge July 26, 2024 13:15
@seangoodvibes
seangoodvibes added this pull request to the merge queue Jul 26, 2024
Merged via the queue into SynthstromAudible:community with commit b25b849 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants