Add stem export config menu for normalization#2330
Merged
m-m-adams merged 1 commit intoJul 28, 2024
Merged
Conversation
Contributor
seangoodvibes
force-pushed
the
Add-Config-Menu-for-Normalization
branch
4 times, most recently
from
c4b0c53 to
a641bae
Compare
seangoodvibes
changed the title
Added configuration submenu with ability to Enable/Disable Normalization Refactored the recorder functions to accept "allowNormalization" as a flag from the caller to exclude normalization from the exported wav file.
seangoodvibes
force-pushed
the
Add-Config-Menu-for-Normalization
branch
from
a641bae to
0f3e689
Compare
Contributor
|
this is great! |
m-m-adams
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the Stem Export menu PR. It adds a new configuration sub-menu with a single configuration setting (to start) to Enable or Disable the normalization of stems prior to export.
Refactored the recorder functions to accept "allowNormalization" as a flag from the caller to exclude normalization from the exported wav file.