Update submenu rendering for toggle's and automatable param's#2345
Merged
sapphire-arches merged 3 commits intoJul 28, 2024
Merged
Conversation
Updated UI for interacting with toggle (ON/OFF) menu's on OLED and 7SEG - OLED renders a checkbox that shows current ON/OFF status. Selecting that menu with select encoder will toggle the checkbox as opposed to entering the menu - 7SEG renders a dot at the end of the menu item to show current ON/OFF status. Selecting that menu with select encoder will toggle the dot as opposed to entering the menu. Submenu's are also now rendered with a ">" at the end to indicate that it is a submenu. There are a couple edge case menu's (e.g. CV / Gate Output, Community Features) that do not inherit these changes but I think those can be addressed as part of a separate PR as they are built differently (don't use toggle or submenu classes).
Submenu's for editing Unpatched and Patched param values now display the current value at the end of each submenu line item
Contributor
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Aug 3, 2024
…tromAudible#2345) * Update Menu UI for interacting with toggle menu's Updated UI for interacting with toggle (ON/OFF) menu's on OLED and 7SEG - OLED renders a checkbox that shows current ON/OFF status. Selecting that menu with select encoder will toggle the checkbox as opposed to entering the menu - 7SEG renders a dot at the end of the menu item to show current ON/OFF status. Selecting that menu with select encoder will toggle the dot as opposed to entering the menu. Submenu's are also now rendered with a ">" at the end to indicate that it is a submenu. There are a couple edge case menu's (e.g. CV / Gate Output, Community Features) that do not inherit these changes but I think those can be addressed as part of a separate PR as they are built differently (don't use toggle or submenu classes). * Render Automatable Param Values in Submenu's Submenu's for editing Unpatched and Patched param values now display the current value at the end of each submenu line item * Fix PR links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Toggle Menu's
Updated UI for interacting with toggle (ON/OFF) menu's on OLED and 7SEG
IMG_0038.mov
IMG_0037.mov
Update Param Menu's
Renders the current value for all automatable unpatched / patched parameters while in the menu
IMG_0061.mov
Update Submenu's
Submenu's are also now rendered with a ">" at the end to indicate that it is a submenu.
Outstanding
There are a couple edge case menu's (e.g. CV / Gate Output, Community Features) that do not inherit these changes but I think those can be addressed as part of a separate PR as they are built differently (they don't use the submenu class).