Repository navigation
learning user scales - #2365
Merged
sapphire-arches merged 6 commits intoAug 5, 2024
Merged
learning user scales#2365
Conversation
nikodemus
force-pushed
the
pr-learn-scale
branch
from
July 31, 2024 11:28
52af89c to
14ef246
Compare
Contributor
Test Results99 tests ±0 99 ✅ ±0 0s ⏱️ ±0s Results for commit 4448b49. ± Comparison against base commit f4a087a. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
nikodemus
force-pushed
the
pr-learn-scale
branch
2 times, most recently
from
August 2, 2024 21:38
05da640 to
34d6d38
Compare
nikodemus
marked this pull request as ready for review
August 2, 2024 21:39
This was referenced Aug 3, 2024
- pass in the key instead of song and root note - deleteEmptyNoteRows was unused, delete - TODO: there's a comment in one place about that: make sure it being unused wasn't just a bug.
nikodemus
force-pushed
the
pr-learn-scale
branch
from
August 4, 2024 12:36
dc4596c to
fac06fe
Compare
- extract scale-related commands into methods of InstrumentClipView. - make AUDITION + SCALE and SCALE + AUDITION both work the same way in and out of scale mode. (Previously AUDITION + SCALE in scale mode was the odd one out.) - LEARN + SCALE learns notes from current & scale mode clips as a new scale.
- Song::userScale stores user scale (there can be only one) - scaleId() -> NUM_PRESET_SCALES for user scales - scale name is always fetched with getScaleName() - OTHER_SCALE and CUSTOM_SCALE_WITH_MORE_THAN_7_NOTES both replaced with USER_SCALE, or CANT_CHANGE_SCALE as appropriate. - propagating the correct type for scale id / index a bit furhter, still remains as int32_t farther out.
- the previous comment abourt noteRowsOnScreen was outdated. No such function exists, and the subsequent noteRows.getNumElements() check actually needs the deletion to work correctly.
nikodemus
force-pushed
the
pr-learn-scale
branch
from
August 4, 2024 12:48
fac06fe to
4448b49
Compare
sapphire-arches
added this pull request to the merge queue
Aug 5, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstrumentClip::seeWhatNotesWithinOctaveArePresent() cleanup
learn + scale learns current notes as custom scale
user scale as part of SHIFT + SCALE cycling