Feature/record from outputs#2371
Merged
m-m-adams merged 18 commits intoAug 4, 2024
Merged
Conversation
Contributor
|
|
||
| Clip* activeClip; | ||
| Clip* activeClip{nullptr}; | ||
| SampleRecorder* recorder{nullptr}; |
Collaborator
There was a problem hiding this comment.
should we prevent this from being used with non-audio outputs? Given the inheritance hierarchy that's likely to be at least a little annoying...
Collaborator
Author
There was a problem hiding this comment.
I'm planning to support instrument outputs in a future PR, just not sure of the UI for how to show the layers yet
E: mixed up PRs, this one supports instruments
Collaborator
Author
There was a problem hiding this comment.
Oh misunderstood - you meant MIDI and CV. Yeah I don't see an obvious way to do that
Co-authored-by: Sapphire Koser <srkoser+GitHub@gmail.com>
Co-authored-by: Sapphire Koser <srkoser+GitHub@gmail.com>
m-m-adams
force-pushed
the
feature/record_from_outputs
branch
from
964dc36 to
a8a966b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows choosing a specific output to record into audio clips
Select TRACK as the source, then there's a menu added for track selection to choose an output