Repository navigation
add ACTIVE SCALES menus, and some USER scale polish - #2376
Merged
seangoodvibes merged 1 commit intoAug 18, 2024
Merged
Conversation
Contributor
nikodemus
force-pushed
the
pr-scale-menu
branch
2 times, most recently
from
August 4, 2024 21:14
c9b21cf to
a2bf691
Compare
Collaborator
Author
|
(On current community loadfw of this fails due to the UB issue, but rebasing on top of eg 8e43e88 works.) |
nikodemus
force-pushed
the
pr-scale-menu
branch
from
August 4, 2024 21:19
a2bf691 to
6b5cbed
Compare
nikodemus
force-pushed
the
pr-scale-menu
branch
4 times, most recently
from
August 7, 2024 20:09
5de6be1 to
a906f76
Compare
nikodemus
changed the title
nikodemus
force-pushed
the
pr-scale-menu
branch
2 times, most recently
from
August 10, 2024 16:03
9cd0cd4 to
99a2925
Compare
nikodemus
changed the title
nikodemus
marked this pull request as ready for review
August 10, 2024 16:04
- SONG > ACTIVE SCALES, and DEFAULTS > SCALE > ACTIVE SCALES. USER is always considered enabled. (This is to keep the flash storage requirement for disabled scales to 2 bytes: we have exactly 16 preset scales right now.) - Toggling a scale off in ACTIVE SCALES removes it from the scale rotation, and from consideration as a random scale. - Keyboard scale mode allows access to USER scale & respects disabled scales as well. - Active scales & USER scale saved explicitly as part of song. - USER scale removed from default scales: we don't save the user scale in flash, so having it as a default doesn't really work, and instead of spending 2 bytes of a scarce resource on it, let's work on support for scales saved on the SD card instead. - Translation between flash storage codes and scale ids moved to one place. - Support for fixed dots with scrolling text on 7-segment display.
nikodemus
force-pushed
the
pr-scale-menu
branch
from
August 14, 2024 08:36
99a2925 to
d6090b6
Compare
seangoodvibes
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This grew a bit more sprawling than I like, so if it's better to split this into smaller chunks, just let me know.