Song Macros Config Mode: Follow up UI changes#2418
Merged
seangoodvibes merged 1 commit intoAug 12, 2024
Merged
Conversation
Contributor
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Song-Macros---Follow-up-Changes
branch
from
fe97244 to
9f45310
Compare
seangoodvibes
changed the title
seangoodvibes
changed the title
Adding some follow-up changes for the new Song Macros Config Mode Instead of using a grid mode, the macros config mode is now accessed from the Song Menu When you enter the Configure menu, it will enter a Context Menu UI which handles switching the underlying Song View into the Grid Config Mode It also handles the pad actions so that you can interact with the grid When you exit out of the Config context menu, it will revert the underlying UI back to its previous state Lastly, while toggling macro types, a pop-up is now shown on the display to tell you what macro type you have selected
seangoodvibes
force-pushed
the
Song-Macros---Follow-up-Changes
branch
from
444c702 to
837e8fb
Compare
seangoodvibes
changed the title
m-m-adams
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some follow-up changes for the new Song Macros Config Mode (PR #1545)
Instead of using a grid mode, the macros config mode is now accessed from the Song Menu
When you enter the Configure menu, it will enter a Context Menu UI which handles switching the underlying Song View into the Grid Config Mode
It also handles the pad actions so that you can interact with the grid
When you exit out of the Config context menu, it will revert the underlying UI back to its previous state
Lastly, while toggling macro types, a pop-up is now shown on the display to tell you what macro type you have selected