Feature/In-Scale Chord view by madeline-scyphers · Pull Request #2475 · SynthstromAudible/DelugeFirmware

madeline-scyphers · 2024-08-22T22:08:53Z

Description

This adds a in-scale chord keyboard view in contrast to the chord library view to build chords easily.

Two modes, row mode and column mode that both color chords by quality (major, minor, dominate, dimished, aug, other).
Has toggleable auto voiceleading mode to keep notes in the same octave (beta features, a much smarter way to do it will come later)
Row Mode:
- Inspired by Launchpad Pro. Each degree of a 7 Note scale laid out on rows. 1 note per pad. First 5 pads of each row are the same as the Launchpad pro (root, 5, 3 + OCT, 7 + OCT, 5 + OCT). After that I selected more notes beyond what the Launchpad pro since the LPP only has 5 notes. I selected notes that any 3 or 4 in a row created nice chords, and any 4 in a row are all unique. With in general, increasing chord complexity as you go right.
Column Mode:
- Each column represents a degree of scale (repeating twice). Different chords of the same quality are played on the pads in a column. So in theory if you are trying to play a chord progression, lets say a I vi IV V, you can trade different chords on the same column with each other to find ones you like. Chords on the same column serve similar harmonic functions.
- In general, more complicated chords are on the top.

The last two columns are reserved for controls right now. Both to switch between modes, and to turn auto voice leading on and off. This is similar to how the Oxi One, the launchpad Pro, and others do it. But this just experimental. Since this is different than current Deluge UI, this could be moved into a chord keyboard menu that is open when the chord keyboard is being used. Or to shortcuts. Or the menu and on the grid.

Horizontal encoder cycles through the scale degrees while the vertical encoder modulates up or down semitones.

Below is an example of using the chord keyboard with row mode then column mode. At the end I use column mode to play a I vi IV V progression with randomly picking chords from those respective columns, showing that each chord in the column can roughly be substituted for another, but give different flavor, allowing users to easily get substitution options.

trim.488CF6C3-7379-44BF-BF69-D53393784DAB.MOV

trim.41A1CFB3-E9F8-4775-909C-97522CDA8E49.MOV

trim.E243F018-04EC-487A-9E94-EC960EA97812.MOV

trim.21C1388F-C457-4743-B212-77FF08D015E1.MOV

github-actions · 2024-08-22T22:13:17Z

Test Results

103 tests ±0 103 ✅ ±0 0s ⏱️ ±0s
15 suites ±0 0 💤 ±0
15 files ±0 0 ❌ ±0

Results for commit 815747b. ± Comparison against base commit 22a65fc.

♻️ This comment has been updated with latest results.

m-m-adams

Generally looks good! Just a couple tweaks to help avoid future issues

m-m-adams · 2024-08-26T21:14:16Z

 extern const Chord kM13;
 extern const Chord kMinor13;

+const std::array<Chord, kDisplayHeight> majorChords = {


This'll probably blow up the bin size again, can the definitions go in the c file?

When it did, the release build right. Like all of the arrays (or vectors, because I originally wanted them as vectors) elements were null, so it got some funky behavior. You can see that behavior with trapper's message here (https://discord.com/channels/608916579421257728/1262843243846959225/1277405330334027919). In the debug build it worked fine split across though.

Though the bin size for my local release build is like 11 kb bigger with it defined in the .h file, so it doesn't seem to be that big of a problem? With the vectors it was like 30 kb bigger I think in the .h, which is why I went with the arrays, even if it meant a little more work in chord_keyboard.cpp. Though if you can figure out how to get it be split, that would be cool?

Yeah the potential problem is that every file that imports this header will create a new copy of the arrays, and what we'd want is all uses to refer to the same underlying data

Being all zeroes sounds like an initialization bug. Vectors need dynamic memory at runtime which might not be set up before they're initialized

It occurred when I swapped them out for arrays too. Want me to push a version with arrays split up so you can check it out?

I split the definition up (as arrays still) and it only plays the root in a column, and the display sometimes produces a random extra symbol. Not sure why. Maybe you can see something I am doing wrong?

Pushed a fix, it's from placing the extern variables in the array instead of referring to them. Arrays own their storage so that means the array got its own copy of the variables which didn't get initialized by chords.cpp.

I just changed that array to hold pointers to the extern const chord lists. This lowers the bin size by avoiding duplication and also ensures that the array holds the correct data

…fill whole column

* initial chord builder keyboard * Color rows by quality * Add auto voiceleading button to keep notes inside 1 octave * Update changelog and community_features for Chord Keyboard * Formatting * Add column mode for playing chords in scale with single press * Display chord in column mode, loop columns when not enough chords to fill whole column * Rename BUILD mode to ROW mode * Reorder Chord Row mode * Fix array declaration bug in release build * Move chord library navigation aid to right column from top row * Fix testing bugs * Add required scale mode to chord keyboard * Restrict properly chord mode to modes of major minor scale * Add encoder actions * Formatting * Fix typo * Add dimming for non tonic degrees * Update changelog and community_features for Chord Keyboard * chord quality arrays in chords.h split definition to chords.cpp * refer to extern chords instead of duplicating * Chord keyboard only plays chords in-scale * Remove melodic and harmonic minor from accepted scales * Formatting and off limits scale popup logic change * Revert logic * Add keyboard control sidebar for controlling keyboard functions * Restores previous sidebar when moving to other keyboard view * Update community_features.md * Fix vertical encoder crash bug * Update community_features.md * Add dedicated chord_keyboard.md features page * Remove navigation column for chord library in scale mode * Switch quality chord contains back to arrays --------- Co-authored-by: m-m-adams <mark.adams@queensu.ca>

* initial chord builder keyboard * Color rows by quality * Add auto voiceleading button to keep notes inside 1 octave * Update changelog and community_features for Chord Keyboard * Formatting * Add column mode for playing chords in scale with single press * Display chord in column mode, loop columns when not enough chords to fill whole column * Rename BUILD mode to ROW mode * Reorder Chord Row mode * Fix array declaration bug in release build * Move chord library navigation aid to right column from top row * Fix testing bugs * Add required scale mode to chord keyboard * Restrict properly chord mode to modes of major minor scale * Add encoder actions * Formatting * Fix typo * Add dimming for non tonic degrees * Update changelog and community_features for Chord Keyboard * chord quality arrays in chords.h split definition to chords.cpp * refer to extern chords instead of duplicating * Chord keyboard only plays chords in-scale * Remove melodic and harmonic minor from accepted scales * Formatting and off limits scale popup logic change * Revert logic * Add keyboard control sidebar for controlling keyboard functions * Restores previous sidebar when moving to other keyboard view * Update community_features.md * Fix vertical encoder crash bug * Update community_features.md * Add dedicated chord_keyboard.md features page * Remove navigation column for chord library in scale mode * Switch quality chord contains back to arrays --------- * Fix bug where in some modes and key combos, it would freeze in infinite while loop * Make chord keyboard exit scale mode * Encoders both only cycle up and down in scale * Embed controls back into chord keyboard * Remove Column Control Sidebar * Remove auto voiceleading until more fully implemented * Update docs Co-Authored-By: m-m-adams <mark.adams@queensu.ca>

madeline-scyphers force-pushed the feature/chord-builder-view branch from fbfbbfa to f85386a Compare August 22, 2024 22:10

madeline-scyphers marked this pull request as draft August 22, 2024 22:10

madeline-scyphers force-pushed the feature/chord-builder-view branch 2 times, most recently from 89ec7f7 to 0b86d0c Compare August 26, 2024 17:37

madeline-scyphers changed the title ~~[DRAFT] Feature/chord builder view~~ Feature/chord builder view Aug 26, 2024

madeline-scyphers marked this pull request as ready for review August 26, 2024 21:54

madeline-scyphers force-pushed the feature/chord-builder-view branch from 6e0bd5e to 54e4cf5 Compare August 26, 2024 21:55

m-m-adams reviewed Aug 26, 2024

View reviewed changes

madeline-scyphers changed the title ~~Feature/chord builder view~~ Feature/In-Scale Chord view Aug 28, 2024

seangoodvibes added the cherry-pick Commit to cherry pick to release branch label Aug 28, 2024

seangoodvibes added this to the Release 1.2 milestone Aug 28, 2024

madeline-scyphers added 18 commits August 30, 2024 15:40

initial chord builder keyboard

3e72786

Color rows by quality

ad2aba7

Add auto voiceleading button to keep notes inside 1 octave

2179e07

Update changelog and community_features for Chord Keyboard

e63f494

Formatting

1a8c033

Add column mode for playing chords in scale with single press

729da4d

Display chord in column mode, loop columns when not enough chords to …

a67bcf3

…fill whole column

Rename BUILD mode to ROW mode

827a7c1

Reorder Chord Row mode

4f42ff5

Fix array declaration bug in release build

02a36e8

Move chord library navigation aid to right column from top row

c13ae3d

Fix testing bugs

f76d53d

Add required scale mode to chord keyboard

56aa531

Restrict properly chord mode to modes of major minor scale

0bed47d

Add encoder actions

3baca62

Formatting

6c7ff2f

Fix typo

66a55bc

Add dimming for non tonic degrees

2d71151

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feature/In-Scale Chord view#2475

Feature/In-Scale Chord view#2475
m-m-adams merged 33 commits into
SynthstromAudible:communityfrom
madeline-scyphers:feature/chord-builder-view

madeline-scyphers commented Aug 22, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2024 •

edited

Loading

Uh oh!

m-m-adams left a comment

Uh oh!

m-m-adams Aug 26, 2024

Uh oh!

madeline-scyphers Aug 26, 2024

Uh oh!

m-m-adams Aug 26, 2024

Uh oh!

madeline-scyphers Aug 26, 2024

Uh oh!

m-m-adams Aug 27, 2024

Uh oh!

madeline-scyphers Aug 27, 2024

Uh oh!

m-m-adams Aug 27, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

madeline-scyphers commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions Bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

m-m-adams left a comment

Choose a reason for hiding this comment

Uh oh!

m-m-adams Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

madeline-scyphers Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

m-m-adams Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

madeline-scyphers Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

m-m-adams Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

madeline-scyphers Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

m-m-adams Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

madeline-scyphers commented Aug 22, 2024 •

edited

Loading

github-actions Bot commented Aug 22, 2024 •

edited

Loading