Highlight incoming MIDI notes and Layout option to display Norns grid input#250
Conversation
stellar-aria
left a comment
There was a problem hiding this comment.
Other than a few style-based things, the logic of this looks good.
I'm a bit concerned about the number of nested ifs in melodic_instrument, but that's a problem for another time 😅
|
I went out of order on the PRs (again) and this one picked up conflicts from one that should have happened later. Sorry about that. |
|
Here's what I've got so far trying to get this to work. Norns code changed:To get awake/awake.lua to work with midigrid, I placed I added deluge as a supported device in midigrid. I modified the file midigrid/lib/supported_devices.lua and added Attached is the lua file for the deluge device type for midigrid. I placed this in midigrid/lib/devices. Github doesn't let me upload .lua files, so I've saved it as a .txt. Please delete TEXT from the filename and save as a .lua file if you use it. Following the example of other device type files, I use generic_device.lua use the default specification, then change it to fit for deluge (width 16, note placement, etc.) Currently, I can press pads and send messages from deluge to norns using a midi clip set to channel 16. I see the LEDs updating on deluge if I learn the incoming midi data from norns to deluge using a different clip, but problems happen when I learn the incoming data to the midi clip sending midi messages out on channel 16. Problem:
Also, each clip on Deluge currently needs to learn the incoming data to have the LEDs update, but this doesn't matter imo because only one clip should be "the monome grid mode clip". If norns-view is enabled in features menu, we could restrict triggering outgoing noteON midi messages from incoming noteON events on channel 1 since midigrid will consume this channel anyway with grid updating stuff, but I'm not sure if that's possible. We'd still want to send outgoing noteON messages, but only if we press a pad on deluge. Another solution would be changing the deluge device type file in midigrid to send control change messages instead of noteON for updating deluge LEDs so it'd be (channel 1, controller, value), I'd have to adjust functions on midigrid side to get that to work, but then it wouldn't trigger noteON's when I learn it to the midi clip. So midigrid could send midi CC messages on channel 1 to update deluge LEDs and listen for noteONs from deluge on channel 1. I think this is the better solution, linnstrument is supported in midigrid in a similar way. Thanks for reading! That's as far as I've gotten. |
|
Midi differentiation seems like it might help a bit, with norns connected I've got din, COMPUTER 1, and COMPUTER 2 showing up as midi devices. I think norns is COMPUTER 1, but I don't know for sure. Here's an updated deluge device type file for midigrid with a commented out section for sending midi CC messages instead of using note_on. Could use a different message like poly aftertouch, I'm not sure which type of midi message interferes the least with other deluge operations. Just need one argument to be 0-127 and the other to have at least 16 values we can map to brightness levels. |
|
I now understand the problem, learning the track means all input is mirrored to the output of the MINI channel. I'll think about how this can be solved in an elegant way |
No description provided.