Feature/warble - #2712
Merged
Merged
Conversation
Contributor
seangoodvibes
approved these changes
Sep 26, 2024
seangoodvibes
added this pull request to the merge queue
Sep 26, 2024
seangoodvibes
removed this pull request from the merge queue due to a manual request
Sep 26, 2024
Collaborator
|
lgtm once you add documentation thx! |
m-m-adams
added this pull request to the merge queue
Sep 27, 2024
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 12, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 12, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 12, 2026
* enable grain fx all the time * add a warble to the modfx * refactor rendering modfx into seperate functions * invert order of checks to reduce branching and render more efficiently * make warble depth controllable * fix global versio * add docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an LFO I've named "Warble", it's a second order filtered sample and hold that produces a random wave something like this:
Adds a Mod fx type I've called "Warbler", which uses this LFO shape to make a flanger/chorus/whatever based modulation abomination that makes super cool lofi warbley noises. It essentially consists of two things, a randomly drifting vibrato and a comb filter. Controls are the normal rate/depth/feedback/offset.
To make a tape warble type thing set rate to 15ish, depth to 5-10, feedback 0-2 and offset at 25
With depth at 0 and feedback at 0 it's not doing anything. If you turn up feedback you'll start to comb filter the signal, offset controls the length of the comb filter. Turning depth up adds modulation to that delay time (like a chorus or flanger) but since the modulation is unpredictable it sounds more "warm" "analog" "chewy" "lofi"
Turning rate up makes it go faster
Turning feedback up makes it get super weird
Turning offset adds phasing (unless feedback is 0, in which case it does nothing)
Also labels the grainfx controls properly since I was touching those menus anyway