Skip to content

Feature/ Make default and last clip type configurable - #2716

Merged
seangoodvibes merged 3 commits into
SynthstromAudible:communityfrom
seangoodvibes:make-default-clip-type-configurable
Sep 27, 2024
Merged

Feature/ Make default and last clip type configurable#2716
seangoodvibes merged 3 commits into
SynthstromAudible:communityfrom
seangoodvibes:make-default-clip-type-configurable

Conversation

@seangoodvibes

@seangoodvibes seangoodvibes commented Sep 27, 2024

Copy link
Copy Markdown
Collaborator

Fix #2704

Grid View

  • The default clip type for new clips created can be configured in SETTINGS > DEFAULTS > UI > CLIP TYPE > NEW CLIP TYPE menu.
    • You can also configure whether the clip type for the next clip type you create should default to the last clip type you created. This helps with fast creation of multiple clips of the same type. You can enable this default setting in the SETTINGS > DEFAULTS > UI > CLIP TYPE > USE LAST CLIP TYPE menu.
    • If you just a tap a pad quickly to create a new clip, it will create that new clip using either the default clip type or the last clip type you created (if you enable this).

Row View

  • Added additional flexibility for creating New Clips in SONG ROW VIEW.
    • The default clip type for new clips created can be configured in SETTINGS > DEFAULTS > UI > CLIP TYPE > NEW CLIP TYPE menu.
      • You can also configure whether the clip type for the next clip type you create should default to the last clip type you created. This helps with fast creation of multiple clips of the same type. You can enable this default setting in the SETTINGS > DEFAULTS > UI > CLIP TYPE > USE LAST CLIP TYPE menu.
      • NOTE: The default clip type / last clip type setting cannot be used with CV clips and Audio clips in Song Row View. If you set the default to CV or Audio or enable use of the last clip type (and the last clip type is a CV or Audio Clip), then it will create a Synth clip by default.

@seangoodvibes seangoodvibes added the cherry-pick Commit to cherry pick to release branch label Sep 27, 2024
@seangoodvibes seangoodvibes added this to the Release 1.2 milestone Sep 27, 2024
@seangoodvibes
seangoodvibes marked this pull request as draft September 27, 2024 03:44
@github-actions

github-actions Bot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

Test Results

103 tests  ±0   103 ✅ ±0   1s ⏱️ -1s
 15 suites ±0     0 💤 ±0 
 15 files   ±0     0 ❌ ±0 

Results for commit 8f79a8b. ± Comparison against base commit 5008003.

♻️ This comment has been updated with latest results.

Add defaults menu to configure default clip type and whether to use last clip type
@seangoodvibes
seangoodvibes force-pushed the make-default-clip-type-configurable branch from d10f28f to 0f2b155 Compare September 27, 2024 04:40
@seangoodvibes seangoodvibes changed the title [DRAFT] Make default and last clip type configurable Make default and last clip type configurable Sep 27, 2024
@seangoodvibes
seangoodvibes marked this pull request as ready for review September 27, 2024 04:45
@seangoodvibes seangoodvibes changed the title Make default and last clip type configurable Fix/ Make default and last clip type configurable Sep 27, 2024
@m-m-adams

Copy link
Copy Markdown
Collaborator

IMO this is too big to cherry pick. It's not a fix it's a new feature

Code looks fine though

@seangoodvibes seangoodvibes removed the cherry-pick Commit to cherry pick to release branch label Sep 27, 2024
@m-m-adams m-m-adams changed the title Fix/ Make default and last clip type configurable Fieature/ Make default and last clip type configurable Sep 27, 2024
@seangoodvibes seangoodvibes changed the title Fieature/ Make default and last clip type configurable Feature/ Make default and last clip type configurable Sep 27, 2024
@m-m-adams
m-m-adams added this pull request to the merge queue Sep 27, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 27, 2024
@seangoodvibes
seangoodvibes added this pull request to the merge queue Sep 27, 2024
Merged via the queue into SynthstromAudible:community with commit 02be727 Sep 27, 2024
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Sep 28, 2024
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
sapphire-arches pushed a commit that referenced this pull request Oct 3, 2024
* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
seangoodvibes added a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
…ble#2716)

* Make default and last clip type configurable

Add defaults menu to configure default clip type and whether to use last clip type

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make default clip type configurable + whether to use last type also configurable

2 participants