Feature // Custom iterance for notes and note rows by soymonitus · Pull Request #2751 · SynthstromAudible/DelugeFirmware

soymonitus · 2024-10-03T13:41:41Z

The idea is to allow later for a view similar to velocity view where you can tap and select the divisor and the enabled steps, allowing you to enter more complex iteration configs for each note like: 1 and 8 out of 8 (=play first and last bars out of 8) ,... or 2, 3 and 4 out of 4 (=play last 3 bars but not the first), etc.

Plan is to use an int16 for the iteration value and store the divisor in the last 8 bits, and use the first 8 bits as booleans to tell if an iteration is enabled or not:

To encode the two previous examples, they will look like this:
000 1000 1000 0001 = this would be divisor = 8, and play bars 1st and 8th
000 0100 0000 1110 = this would be divisor = 4, and play bars 2nd, 3rd and 4th

Check if all menus update when changing selected note or row
Move the custom iterance menu inside the iterance parameter when clicking select while CUSTOM is selected
Cleanup
Documentation

github-actions · 2024-10-03T13:43:19Z

Test Results

103 tests ±0 103 ✅ ±0 0s ⏱️ ±0s
15 suites ±0 0 💤 ±0
15 files ±0 0 ❌ ±0

Results for commit ac5ac7f. ± Comparison against base commit daf3ff8.

♻️ This comment has been updated with latest results.

soymonitus · 2024-10-03T14:18:38Z

@seangoodvibes ready for review. Everything working now

soymonitus · 2024-10-04T05:11:17Z

@seangoodvibes that is weird. It compiles and works for me. Did you try he build generated by GitHub?

seangoodvibes · 2024-10-04T13:18:15Z

@soymonitus weird it's working now and I think the iterance is all working!

seangoodvibes · 2024-10-04T13:20:08Z

@soymonitus can you check the saving / loading code? It's not re-loading the custom iterance for me

soymonitus · 2024-10-04T13:37:51Z

@soymonitus can you check the saving / loading code? It's not re-loading the custom iterance for me

Ok i will check now, maybe there is some omision somewhere

soymonitus · 2024-10-04T14:54:17Z

@soymonitus can you check the saving / loading code? It's not re-loading the custom iterance for me

Ok, now it is fixed for sure, tested that I was able to write and read songs and iterance is preserved.

seangoodvibes · 2024-10-05T04:53:17Z

Hi @soymonitus I noticed a couple other bugs

First one is a UI bug: I have fixed this here #2770
https://github.com/user-attachments/assets/107afb75-829b-43ec-9f7f-9d21d5186071

Second one:

changing row iterance doesn't change note iterance of existing notes (e.g. I set row iterance to 1 of 8 and existing note got set to custom 1 of 1).

…notes

seangoodvibes · 2024-10-06T15:37:23Z

+			int32_t divisor = val << 8;
+			// Wipe the bits whose index is greater than the current divisor value
+			int32_t newIterance = ((iterance & 0xFF) & mask) | divisor;
+			leftMostNote->setIterance(newIterance);


this is wrong as it's only setting the iterance for the left most note in a square. It needs to adjust the iterance for all notes in that square. that's what the instrumentClipView.adjustNoteIterance(offset) function does.

So you'll need a setNoteCustomiterance function to set the iterances of all notes in the square.

seangoodvibes · 2024-10-06T15:37:33Z

+			else {
+				iterance &= ~(1 << index);
+			}
+			leftMostNote->setIterance(iterance);


this is wrong as it's only setting the iterance for the left most note in a square. It needs to adjust the iterance for all notes in that square. that's what the instrumentClipView.adjustNoteIterance(offset) function does.

So you'll need a setNoteCustomiterance function to set the iterances of all notes in the square.

soymonitus · 2024-10-06T21:46:32Z

Hi Sean, I did a refactor to avoid code duplication, making use of the code inside adjustNoteParameter and setNoteRowParameter to accept either an offset or the final value, so in each case just a small piece of code is differently handled, but the rest is the same for both

Re-enabled editing note / note row iterance using note / audition pad + turning select encoder - To edit probability, hold a note / audition pad and turn the select encoder to the left to display current probability value / set new probability value. - To edit iterance, hold a note / audition pad and turn the select encoder to the right to display current iterance value / set new iterance value.

…#2751) * Implemented custom iterance * Cleanup * Implement submenu under iterance’s CUSTOM value * Fix * Documentation * Cleanup and documentation * Fixed reading custom iterance * Fixed sanitizeIterance method. Typo when calculating the divisor * fix * When custom iterance is modified in note row, apply same iternace to notes * Refactor code to avoid repetition * dbt format * fix * Re-enable editing iterance with select encoder Re-enabled editing note / note row iterance using note / audition pad + turning select encoder - To edit probability, hold a note / audition pad and turn the select encoder to the left to display current probability value / set new probability value. - To edit iterance, hold a note / audition pad and turn the select encoder to the right to display current iterance value / set new iterance value. * Fix bug with blurred notes * Allow editing iterance turning the select encoder right while holding the note * Fix merge resolution mistake * Misc fixes - Moving knob right when you are at CUSTOM iterance will not reset the custom iterance set. It respects what is there (see code around “originalParameter”) - Changing the iterance directly turning select knob while holding note will now NOT allow moving past 8 of 8, and if already on Custom, it won’t let you go left to the presets * Fixed bug with blurred notes * docs * Save Iterance as an struct instead of a plain uint16 * Renaming * renaming stuff * Refactor some methods inside the Iterance struct * Refactor to include methods as part of the struct * Added menu hierarchies * update community_features.md Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com>

Implemented custom iterance

69607c0

soymonitus added 4 commits October 3, 2024 15:47

Cleanup

db34dee

Implement submenu under iterance’s CUSTOM value

587d61e

Fix

fc087ea

Documentation

77d9ca6

Cleanup and documentation

5cd3fc2

soymonitus added 4 commits October 4, 2024 16:33

Fixed reading custom iterance

646e2c2

Fixed sanitizeIterance method. Typo when calculating the divisor

cf91b80

fix

bb3cda2

Merge branch 'community' into monitus/custom_iterance_menu

ad82d56

SynthstromAudible deleted a comment from soymonitus Oct 5, 2024

When custom iterance is modified in note row, apply same iternace to …

43151a4

…notes

seangoodvibes reviewed Oct 6, 2024

View reviewed changes

soymonitus added 2 commits October 6, 2024 23:44

Refactor code to avoid repetition

bc10780

Merge branch 'community' into monitus/custom_iterance_menu

9115bf4

soymonitus and others added 5 commits October 7, 2024 01:25

dbt format

3687a70

fix

2d3ad91

Fix bug with blurred notes

ea5ab4e

Merge branch 'community' into monitus/custom_iterance_menu

d741600

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature // Custom iterance for notes and note rows#2751

Feature // Custom iterance for notes and note rows#2751
seangoodvibes merged 36 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/custom_iterance_menu

soymonitus commented Oct 3, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

soymonitus commented Oct 3, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 4, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 5, 2024 •

edited

Loading

Uh oh!

seangoodvibes Oct 6, 2024 •

edited

Loading

Uh oh!

seangoodvibes Oct 6, 2024 •

edited

Loading

Uh oh!

soymonitus commented Oct 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

soymonitus commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

soymonitus commented Oct 3, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 4, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

soymonitus commented Oct 4, 2024

Uh oh!

seangoodvibes commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seangoodvibes Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seangoodvibes Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soymonitus commented Oct 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

soymonitus commented Oct 3, 2024 •

edited

Loading

github-actions Bot commented Oct 3, 2024 •

edited

Loading

seangoodvibes commented Oct 5, 2024 •

edited

Loading

seangoodvibes Oct 6, 2024 •

edited

Loading

seangoodvibes Oct 6, 2024 •

edited

Loading