Added LPF filter to MI reverb - #2788
Merged
Merged
Conversation
m-m-adams
reviewed
Oct 9, 2024
markyounq
marked this pull request as ready for review
October 10, 2024 08:50
markyounq
changed the title
Collaborator
|
Could you add saving/loading code before we merge? It would also be nice to have this as a feature on both reverbs as a follow up. It would require refactoring so that the specific reverb process function writes to an intermediate buffer where we run the filters |
Contributor
m-m-adams
reviewed
Oct 10, 2024
Contributor
Author
I'm not sure what you mean. Saving/loading the reverb LPF cutoff?
Agreed but I don't think I'll cover it in this PR |
markyounq
commented
Oct 11, 2024
Collaborator
Yeah just needs to be added to the reverb block in the song-> read/write from file functions here DelugeFirmware/src/deluge/model/song/song.cpp Line 1144 in ba1581c |
stellar-aria
requested changes
Oct 12, 2024
Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
* Added LPF filter to MI reverb * added LPF.h file * Fixed LPF so it applies to both channels * added initialization of reverb default * testing defaults * more LPF default testing. init LPF in base reverb * fixed typo in LPF init * more default testing * edited song params for default reverb * fixing calcfiltercutoff to work for both LPF and HPF ranges * added param to function calls * added filter type to scope of init * changed min reverb LPF cutoff to 0hz * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/base.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * Update src/deluge/dsp/reverb/mutable/reverb.hpp Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> * added save/write to song * added template to reverb base * edit LPF init * added LPF to global kit FX * edited comments to match new Hz * updating docs * ran format --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP adding LPF filter to the Mutable Instruments reverb engine.