Skip to content

Feature/grain improvements#2815

Merged
stellar-aria merged 10 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/grain_improvements
Oct 31, 2024
Merged

Feature/grain improvements#2815
stellar-aria merged 10 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/grain_improvements

Conversation

@m-m-adams
Copy link
Copy Markdown
Collaborator

Make grain sound better

  • Add an lpf on the grain output to filter out some pitch artifacts
  • Add a bit of extra reverb to cover up any discontinuities
  • Switch from clamping to scaling all params so entire range is useful
  • Switch from 5 presets to a sliding "randomness" that increases the probability of bigger shifts and reverse grains
  • Switch from a size to a "density" param, which scales from almost 0 to 800% grain coverage(e.g. always 8 grains playing at once). This allows rate to be changed without affecting the density of the sound

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 15, 2024

Test Results

103 tests  ±0   103 ✅ ±0   0s ⏱️ ±0s
 15 suites ±0     0 💤 ±0 
 15 files   ±0     0 ❌ ±0 

Results for commit 2d9c5aa. ± Comparison against base commit b6493bd.

♻️ This comment has been updated with latest results.

@stellar-aria stellar-aria added this pull request to the merge queue Oct 31, 2024
Merged via the queue into SynthstromAudible:community with commit 7bdf858 Oct 31, 2024
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* granular tweaks

* switch grain preset to continuous randomness

* cache previous setup and fix up param names

* filter grains slightly

* fix up grain param names

* change to triangle distribution

* scale grain reverb send by reverb amount

* format and rename function for clarity

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants