Add midi device definition file support - #2823
Merged
seangoodvibes merged 3 commits intoNov 3, 2024
Merged
Conversation
Contributor
seangoodvibes
force-pushed
the
MIDI-Device-Definition
branch
7 times, most recently
from
October 19, 2024 15:52
78613c2 to
460d2fc
Compare
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
force-pushed
the
MIDI-Device-Definition
branch
from
October 20, 2024 21:50
016d15c to
f658003
Compare
Collaborator
Collaborator
Author
Collaborator
|
Yeah you're right, happens without the PR too. I don't think it really matters anyway |
m-m-adams
approved these changes
Nov 3, 2024
seangoodvibes
added this pull request to the merge queue
Nov 3, 2024
RJ-Eckie
pushed a commit
to RJ-Eckie/DelugeFirmware
that referenced
this pull request
Feb 15, 2025
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 11, 2026
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a `MIDI preset`, with the `Song`, or to a `MIDI device definition file`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



MIDI Device Definition Files
Description
Added ability to rename MIDI CC's in MIDI clips. Changes are saved by Instrument (e.g. per MIDI channel). Changes can be saved to a
MIDI preset, with theSong, and to aMIDI device definition file.The
MIDI Device Definition Fileis saved on the SD Card in the folder path:MIDI_DEVICES/DEFINITION/.Updated MIDI CC name's will be displayed when pressing / turning the
Gold (Mod) Encoderthe CC is assigned to and also when automating that CC inAutomation ViewRename a MIDI CC
To rename a
MIDI CC, enterAutomation Viewand select the CC you wish to rename using theSelect Encoderor using theGrid Shortcut.With the
MIDI CCselected, pressShift+ theNamegrid shortcut to open theMIDI CC Renaming UI. Enter a new name and pressSelectorEnter.The new
MIDI CCname will be immediately visible inAutomation Viewand you can assign that CC to aGold Knobin the MIDI clip and it will show that name when you press down on theGold (Mod) Encoderand when you turn theGold (Mod) Encoderto change the CC value.Save MIDI CC Name(s)
If you made changes to the name of a
MIDI CC, they will need to be saved so that you can use them should you reboot the Deluge. They can be saved to theSong, to aMIDI Presetor to aMIDI Device Definition File.Save to the Song
Simply save the song by pressing
SaveIf you had previously linked a
MIDI Device Definition Fileto the Song, then the file path to that definition file will be saved to the Song.In addition, the last edited midi cc name(s)'s will also be saved with the song in case the
MIDI Device Definition Filecannot be found.Save to the MIDI Preset
While in the MIDI clip, press
Save + MIDIIf you had previously linked a
MIDI Device Definition Fileto the MIDI Instrument, then the file path to that definition file will be saved to the preset.In addition, the last edited midi cc name(s)'s will also be saved with the preset in case the
MIDI Device Definition Filecannot be found.Save to the MIDI Device Definition File
To save the
MIDI CClabels to aMIDI Device Definition File, holdSave+ Press down on eitherGold (Mod) Encoder. It will ask you to enter a file name. PressSelect,Enter on the KeyboardorSaveto save the file.A
MIDI Device Definition Fileis saved on the SD Card in the folder path:MIDI_DEVICES/DEFINITION/.Load MIDI CC Name(s)
Load with the Song
When you load a song for which MIDI CC name changes were previously saved, those name changes will be re-loaded.
If you linked the Song to a
MIDI Device Definition File, then the changes will be loaded from that definition file.If the Song is not linked to a definition file, then the name changes will be loaded from the Song.
Load from Midi Preset
When you load a MIDI preset for which MIDI cc name changes were previously saved, those name changes will be re-loaded.
If you linked the preset to a
MIDI Device Definition File, then the changes will be loaded from that definition file.If the preset is not linked to a definition file, then the name changes will be loaded from the preset.
Load from Midi Device Definition File
To load the
MIDI CClabels from aMIDI Device Definition File, holdLoad+ Press down on eitherGold (Mod) Encoder. It will ask you to select a file. PressSelect,Enter on the KeyboardorLoadto load the file.Saving or Loading a
MIDI Device Definition Filewill link that file to the current MIDI Instrument in the current song. If you save the song or save the current midi instrument as a preset, the song file and midi instrument preset file will include a file path to theMIDI Device Definition File. If you re-load the song or re-load the midi instrument preset, it will load information from the linkedMIDI Device Definition File.Linking / Unlinking a MIDI Device Definition File
You can unlink a Song or Midi Instrument preset from the a
MIDI Device Definition Filevia theMIDI > Device Definition (DEVI)menu. You will need to re-save the song and/or preset to save the changes.You can also manually unlink the song file / preset file from the
MIDI Device Definition Fileby searching fordefinitionFile. You should seename="***"right under it. Do not delete the name line from the preset. Instead replace the name withname=""You can also use the
MIDI > Device Definitionmenu as another way to link / load aMIDI Device Definition File. When clicking on theFile Linked (LINK)setting, it will prompt you to select aMIDI Device Definition Fileto load. After successfully loading the file, the file name will be displayed (on OLED only) below theFile Linkedsetting.Tips and Tricks
Scenario: I want to load a
MIDI Device Definition Filebut make changes to the CC labels afterwardsFirstly, when you load a
MIDI Device Definition File, the song will become linked to that file. If you wish to make changes to the cc labels, you will need to either:A) unlink the song from the
MIDI Device Definition Fileand make changes to the labels and save them to the song,or
B) you will need to save those label changes back to a
MIDI Device Definition Fileand save the song so that it reloads from that file.A) Make changes to labels without updating
MIDI Device Definition FileTLDR steps:
If you loaded a
MIDI Device Definition Fileand now wish to make changes, but don't wish to save those changes to thatMIDI Device Definition Fileor another definition file (e.g. you want to keep your changes specific to the Song / MIDI preset), thenAs a preliminary step, after loading a
MIDI Device Definition File, go to theMIDI > Device Definitionmenu. It will show if aMIDI Device Definition Fileis linked. PressSELECTonFile Linked (LINK)to unlink that file.Now you can go follow the steps to update CC Labels.
After updating the CC Labels, save your changes to the Song and/or to a MIDI preset.
When you re-load the Song or MIDI preset next time, it will load the CC labels from the Song or MIDI preset and not from the
MIDI Device Definition Fileyou started with.B) Make changes to labels and update
MIDI Device Definition FileTLDR steps:
If you loaded a song and loaded a
MIDI Device Definition Fileand now want to make changes to CC Labels, or you just started making changes as part of that song, you can save those changes back to the same or a newMIDI Device Definition File.After you have saved the changes to the
MIDI Device Definition File, you will need to Save the song and/or MIDI preset to link the Song / Preset to thatMIDI Device Definition File.When you re-load the Song or MIDI preset next time, it will load the CC labels from the
MIDI Device Definition File. The Song or MIDI preset will also keep a copy of those changes in case theMIDI Device Definition Fileis removed from your SD card.Midi Device Definition File Layout
The same information saved to the Midi Device Definition File is also saved to the Song / MIDI Preset with the exception of the Definition File Name which is not saved to the Definition File.