Skip to content

Feature/dimension#2882

Merged
m-m-adams merged 5 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/dimension
Nov 11, 2024
Merged

Feature/dimension#2882
m-m-adams merged 5 commits into
SynthstromAudible:communityfrom
m-m-adams:feature/dimension

Conversation

@m-m-adams
Copy link
Copy Markdown
Collaborator

Adds a boss dimension c style mod fx. Works best in stereo but is still distinct from the chorus in mono. It'll render automatically in stereo if the deluge is rendering in stereo

This is based on the refactorings from the stereo warble PR, I'll rebase when that's merged

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2024

Test Results

103 tests  ±0   103 ✅ ±0   0s ⏱️ ±0s
 15 suites ±0     0 💤 ±0 
 15 files   ±0     0 ❌ ±0 

Results for commit 2f2a6fa. ± Comparison against base commit d6e59a9.

♻️ This comment has been updated with latest results.

@seangoodvibes
Copy link
Copy Markdown
Collaborator

Documentation please :D ❤️

@m-m-adams m-m-adams added this pull request to the merge queue Nov 11, 2024
Merged via the queue into SynthstromAudible:community with commit 836a559 Nov 11, 2024
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 11, 2026
* dimension effect

* format

* fix it for global effectables

* add doc entry

* the warbler sounds more warbly and less modulationy this way too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants